Use LazyEval instead of Lazy in C2PODomain. #1717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI failures for marshalling tests that occur with C2PO in the ulocked pipeline.
The failure of the marshalling tests for C2PO is due to the normal form that appears as part of the domain of C2PO, being
Lazy.t. Thus, these normal forms are of a functional value that cannot be marshaled.This PR changes this by using
LazyEvalin place ofLazy. Then, the input data for the computation of the normal form --- the other record entries of the domain --- are kept instead of a closure capturing these values. Theevalthat is defined then performs the evaluation of the normal form.