Explicitly specify no-argument function pointers in tests

tests/incremental/11-restart/11-paper-example.c

@@ -3,7 +3,7 @@
 
 pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
 
-int (*fp)() = NULL;
+int (*fp)(void) = NULL;
 
 int bad() {
     return -1;

tests/regression/00-sanity/15-unused_arg.c

@@ -4,9 +4,9 @@ void f() {
   glob++; // NOWARN!
 }
 
-void (*fptr) = f;
+void (*fptr)(void) = f;
 
-int g(void (*ptr)()) {
+int g(void (*ptr)(void)) {
   return 0;
 }
 

tests/regression/00-sanity/38-evalfunvar-dead.c

@@ -1,7 +1,7 @@
 #include <stdlib.h>
 
 int main() {
-  int (*fp)() = &rand;
+  int (*fp)(void) = &rand;
   abort();
   fp(); // NOWARN (No suitable function to call)
   return 0;

tests/regression/01-cpa/06-pointers.c

@@ -8,7 +8,7 @@ int fun_5b() { return 5; }
 int main () {
   int i,j,k1,k2,k3;
   int *p, **pp;
-  int (*fp)(); //pointer to function
+  int (*fp)(void); //pointer to function
 
   // reading through pointer
   i = 5;

tests/regression/01-cpa/09-arrays.c

@@ -18,9 +18,9 @@ int main () {
 
   int a[] = {2,2,2};
   int b[2], c[3];
-  int (*f[2])() = {fun_5, fun_6};
-  int (*g[2])() = {fun_5, fun_5b};
-  int (*fp)();
+  int (*f[2])(void) = {fun_5, fun_6};
+  int (*g[2])(void) = {fun_5, fun_5b};
+  int (*fp)(void);
   int *ip;
   int (*iap)[];
 

tests/regression/01-cpa/46-funptr_path.c

@@ -16,7 +16,7 @@ void fun2() {
 int main() {
   int x = __VERIFIER_nondet_int();
 
-  void (*fp)();
+  void (*fp)(void);
 
   if (x) {
     pthread_mutex_lock(&mutex);

tests/regression/02-base/46-spawn-global-funptrs.c

@@ -9,13 +9,13 @@ void bar() {
   __goblint_check(1); // assert reachable
 }
 
-void (*funs[2])() = {
+void (*funs[2])(void) = {
   &foo,
   &bar
 };
 
 extern void magic1();
-extern void magic2(void (*funs[])());
+extern void magic2(void (*funs[])(void));
 
 int main() {
   magic1(); // invalidate funs a bit

tests/regression/03-practical/06-callback.c

@@ -9,7 +9,7 @@ void callme(void)  {
   x = 5;
 }
 
-void callfun(void (*fun)()) {
+void callfun(void (*fun)(void)) {
   fun();
   return;
 }

tests/regression/04-mutex/19-call_by_ptr_rc.c

@@ -2,7 +2,7 @@ extern int __VERIFIER_nondet_int();
 
 #include<pthread.h>
 
-void foo(int (*callback)()) {
+void foo(int (*callback)(void)) {
   for (int i = 0; i < 10; i++) {
     if (__VERIFIER_nondet_int())
       callback();

tests/regression/04-mutex/21-sound_base.c

@@ -6,7 +6,7 @@ int global;
 void bad() { global++; } // RACE!
 void good() { printf("Hello!"); }
 
-void (*f)() = good;
+void (*f)(void) = good;
 
 void *t_fun(void *arg) {
   f(); // RACE!

tests/regression/04-mutex/27-base_rc.c

@@ -13,11 +13,11 @@ void good() {
   pthread_mutex_unlock(&gm);
 }
 
-void (*f)() = good;
+void (*f)(void) = good;
 pthread_mutex_t fm = PTHREAD_MUTEX_INITIALIZER;
 
 void *t_fun(void *arg) {
-  void (*g)();
+  void (*g)(void);
 
   pthread_mutex_lock(&fm);
   g = f; // NORACE

tests/regression/04-mutex/28-base_nr.c

@@ -13,11 +13,11 @@ void good() {
   pthread_mutex_unlock(&gm);
 }
 
-void (*f)() = good;
+void (*f)(void) = good;
 pthread_mutex_t fm = PTHREAD_MUTEX_INITIALIZER;
 
 void *t_fun(void *arg) {
-  void (*g)();
+  void (*g)(void);
 
   pthread_mutex_lock(&fm);
   g = f; // NORACE

tests/regression/04-mutex/29-funstruct_rc.c

@@ -7,7 +7,7 @@ pthread_mutex_t B_mutex = PTHREAD_MUTEX_INITIALIZER;
 
 struct ops {
   int (*f)(int);
-  void (*g)();
+  void (*g)(void);
 };
 
 extern void register_dev(struct ops *);

tests/regression/04-mutex/30-funstruct_nr.c

@@ -7,7 +7,7 @@ pthread_mutex_t B_mutex = PTHREAD_MUTEX_INITIALIZER;
 
 struct ops {
   int (*f)(int);
-  void (*g)();
+  void (*g)(void);
 };
 
 extern void register_dev(struct ops *);

tests/regression/04-mutex/50-funptr_rc.c

@@ -5,7 +5,7 @@
 int f1() { return 4; }
 int f2() { return 5; }
 
-int (*fp)() = f1;
+int (*fp)(void) = f1;
 
 pthread_mutex_t mutex1 = PTHREAD_MUTEX_INITIALIZER;
 pthread_mutex_t mutex2 = PTHREAD_MUTEX_INITIALIZER;

tests/regression/04-mutex/56-extern_call_by_ptr_rc.c

@@ -1,6 +1,6 @@
 #include<pthread.h>
 
-extern void foo(int (*callback)());
+extern void foo(int (*callback)(void));
 
 
 int glob;

tests/regression/13-privatized/95-mm-calloc.c

@@ -3,7 +3,7 @@
 #include<stdlib.h>
 #include<stdio.h>
 struct a {
-  void (*b)();
+  void (*b)(void);
 };
 
 int g = 0;

tests/regression/22-partitioned_arrays/05-adapted_from_01_09_array.c

@@ -19,9 +19,9 @@ int main () {
 
   int a[] = {2,2,2};
   int b[2], c[3];
-  int (*f[2])() = {fun_5, fun_6};
-  int (*g[2])() = {fun_5, fun_5b};
-  int (*fp)();
+  int (*f[2])(void) = {fun_5, fun_6};
+  int (*g[2])(void) = {fun_5, fun_5b};
+  int (*fp)(void);
   int *ip;
   int (*iap)[];
 

tests/regression/23-partitioned_arrays_last/05-adapted_from_01_09_array.c

@@ -19,9 +19,9 @@ int main () {
 
   int a[] = {2,2,2};
   int b[2], c[3];
-  int (*f[2])() = {fun_5, fun_6};
-  int (*g[2])() = {fun_5, fun_5b};
-  int (*fp)();
+  int (*f[2])(void) = {fun_5, fun_6};
+  int (*g[2])(void) = {fun_5, fun_5b};
+  int (*fp)(void);
   int *ip;
   int (*iap)[];
 

tests/regression/28-race_reach/19-callback_racing.c

@@ -4,7 +4,7 @@ extern int __VERIFIER_nondet_int();
 #include<pthread.h>
 #include "racemacros.h"
 
-void foo(int (*callback)()) {
+void foo(int (*callback)(void)) {
   for (int i = 0; i < 10; i++) {
     if (__VERIFIER_nondet_int())
       callback();

tests/regression/28-race_reach/20-callback_racefree.c

@@ -4,7 +4,7 @@ extern int __VERIFIER_nondet_int();
 #include<pthread.h>
 #include "racemacros.h"
 
-void foo(int (*callback)()) {
+void foo(int (*callback)(void)) {
   for (int i = 0; i < 10; i++) {
     if (__VERIFIER_nondet_int())
       callback();

tests/regression/28-race_reach/27-funptr_racing.c

@@ -16,11 +16,11 @@ void good() {
   pthread_mutex_unlock(&gm);
 }
 
-void (*f)() = good;
+void (*f)(void) = good;
 pthread_mutex_t fm = PTHREAD_MUTEX_INITIALIZER;
 
 void *t_fun(void *arg) {
-  void (*g)();
+  void (*g)(void);
 
   pthread_mutex_lock(&fm);
   g = f;

tests/regression/28-race_reach/28-funptr_racefree.c

@@ -15,11 +15,11 @@ void good() {
   pthread_mutex_unlock(&gm);
 }
 
-void (*f)() = good;
+void (*f)(void) = good;
 pthread_mutex_t fm = PTHREAD_MUTEX_INITIALIZER;
 
 void *t_fun(void *arg) {
-  void (*g)();
+  void (*g)(void);
 
   pthread_mutex_lock(&fm);
   g = f;

tests/regression/28-race_reach/95-deref-fun.c

@@ -1,7 +1,7 @@
 // PARAM: --enable ana.sv-comp.enabled --set ana.specification "CHECK( init(main()), LTL(G ! call(reach_error())) )"
 #include<pthread.h>
 // NOCRASH
-void foo(int (*callback)()) {
+void foo(int (*callback)(void)) {
 }
 
 int bar() {

tests/regression/67-interval-sets-two/18-adapted_from_01_09_array.c

@@ -19,9 +19,9 @@ int main () {
 
   int a[] = {2,2,2};
   int b[2], c[3];
-  int (*f[2])() = {fun_5, fun_6};
-  int (*g[2])() = {fun_5, fun_5b};
-  int (*fp)();
+  int (*f[2])(void) = {fun_5, fun_6};
+  int (*g[2])(void) = {fun_5, fun_5b};
+  int (*fp)(void);
   int *ip;
   int (*iap)[];
 

tests/sv-comp/cfg/free_spawn_ub_true-unreach-call.c

@@ -8,7 +8,7 @@ void foo()
 
 int main()
 {
-    void (*p)() = &foo;
+    void (*p)(void) = &foo;
     free(p); // TODO: free shouldn't spawn
     return 0;
 }

tests/sv-comp/cfg/free_spawn_ub_true-unreach-call.expected

@@ -1,27 +1,27 @@
-┌───────────────────────────────────┐
-│                 _                 │
-└───────────────────────────────────┘
+┌─────────────────────┐
+│          _          │
+└─────────────────────┘
   │
   │ Entry main
   ▼
-┌───────────────────────────────────┐
-│                 _                 │
-└───────────────────────────────────┘
+┌─────────────────────┐
+│          _          │
+└─────────────────────┘
   │
-  │ Assign 'p = (void (*)())(& foo)'
+  │ Assign 'p = & foo'
   ▼
-┌───────────────────────────────────┐
-│                 _                 │
-└───────────────────────────────────┘
+┌─────────────────────┐
+│          _          │
+└─────────────────────┘
   │
   │ Proc 'free(p)'
   ▼
-┌───────────────────────────────────┐
-│                 _                 │
-└───────────────────────────────────┘
+┌─────────────────────┐
+│          _          │
+└─────────────────────┘
   │
   │ Ret (Some 0, main)
   ▼
-┌───────────────────────────────────┐
-│                 _                 │
-└───────────────────────────────────┘
+┌─────────────────────┐
+│          _          │
+└─────────────────────┘