Skip to content

Remove IntDomain.Size.top_typ #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sim642 merged 2 commits into from
May 8, 2025
Merged

Remove IntDomain.Size.top_typ #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ddd5cf
Remove IntDomain.Size.top_typ
sim642 May 7, 2025
4bb4437
Use GoblintCil.upointType directly
sim642 May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/cdomain/value/cdomains/intDomain0.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ module Size = struct (* size in bits as int, range as int64 *)
open Cil
let sign x = if Z.compare x Z.zero < 0 then `Signed else `Unsigned

let top_typ = TInt (ILongLong, [])
let min_for x = intKindForValue x (sign x = `Unsigned)
let bit = function (* bits needed for representation *)
| IBool -> 1
Expand Down
2 changes: 0 additions & 2 deletions src/cdomain/value/cdomains/intDomain_intf.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,6 @@ sig


module Size : sig
(** The biggest type we support for integers. *)
val top_typ : Cil.typ
val range : Cil.ikind -> Z.t * Z.t
val is_cast_injective : from_type:Cil.typ -> to_type:Cil.typ -> bool
val bits : Cil.ikind -> int * int
Expand Down
4 changes: 2 additions & 2 deletions src/cdomain/value/cdomains/valueDomain.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ struct
| (x, Top) -> x
| (Int x, Int y) -> Int (ID.meet x y)
| (Float x, Float y) -> Float (FD.meet x y)
| (Int _, Address _) -> meet x (cast (TInt(Cilfacade.ptr_ikind (),[])) y)
| (Int _, Address _) -> meet x (cast !GoblintCil.upointType y)
| (Address x, Int y) -> Address (AD.meet x (AD.of_int y))
| (Address x, Address y) -> Address (AD.meet x y)
| (Struct x, Struct y) -> Struct (Structs.meet x y)
Expand All @@ -727,7 +727,7 @@ struct
match (x,y) with
| (Int x, Int y) -> Int (ID.narrow x y)
| (Float x, Float y) -> Float (FD.narrow x y)
| (Int _, Address _) -> narrow x (cast IntDomain.Size.top_typ y)
| (Int _, Address _) -> narrow x (cast !GoblintCil.upointType y)
| (Address x, Int y) -> Address (AD.narrow x (AD.of_int y))
| (Address x, Address y) -> Address (AD.narrow x y)
| (Struct x, Struct y) -> Struct (Structs.narrow x y)
Expand Down
Loading