-
Notifications
You must be signed in to change notification settings - Fork 88
Use access events in MemOutOfBounds analysis #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
karoliineh
wants to merge
15
commits into
master
Choose a base branch
from
oob-event
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+143
−352
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c1149df
Check for warn if pointer is dereferenced past end
karoliineh e14c553
Account for stored pointer offsets in deref checks
karoliineh 1948593
Refactor: extract pointer arithmetic offset helpers
karoliineh 2132d73
Refactor: inline pointer-arithmetic checks and simplify binop handling
karoliineh 7921e08
MemOutOfBounds: check accesses from access events
karoliineh 502ef63
Remove unused function
karoliineh d685a42
Extract ptr deref part into own fun to make `check_access_for_oob`cas…
karoliineh 71a7cd3
Extract common category and tags to top level and move computations i…
karoliineh 2c2fa2a
Actually use the addr from event in `check_ptr_value_access`
karoliineh c5eadfa
Remove redundant warnings from offset calculations
karoliineh 83e65c2
Change warning messages and promote
karoliineh 074e4d7
Refactor excessive warn msg duplication into helper functions
karoliineh 2ad23f6
Refactor: extract duplicate code into helper function
karoliineh 29da285
Move and simplify `ptr_only_has_str_addr`
karoliineh bf7daff
Simplify `may_contain_unknown_addr`
karoliineh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do this TODO here? Seems simple.