-
Notifications
You must be signed in to change notification settings - Fork 88
Extract function and node specific logic from TD3 #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2022
Merged
2078580 to
7b06f1b
Compare
jerhard
reviewed
Nov 23, 2022
jerhard
approved these changes
Nov 30, 2022
Member
jerhard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue #545.
This is a quick idea I had to move all the incrementally changed functions stuff out of TD3. The point is to expose separate constraint system incremental data to TD3, which just lists the unknowns to obsolete, delete and reluctantly resolve. These lists are populated by
FromSpecitself, which is the last thing that still should know about the specifics of the constraints.With this change it's actually unnecessary for the solver to even have access to
iter_varsfrom #549 becauseFromSpecuses it directly to do the conversion.This is currently on top of #391 although something similar could be done on master as well. Although the annoyance is that it would have to be essentially redone completely there since the changes code in TD3 is changed significantly by #391, particularly by #549.TODO
iter_varsaccess from solver.