Remove inthack and fix i-lock star display
#749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long while now, the i-lock star (denoting symbolic index-based locking) hasn't been nicely printed. For example, the warning for the website example shows
def_exc:-19012009as the index:After this PR, this is fixed to display the indented and more user-friendly
*in its place, as it was originally intended:This removes the global
inthackaltogether and changes thePrintableused for those i-lock accesses to use a custom implementation that explicitly only has unknown and star indices in offsets. During the expression transformation,staris no longer an integer constant withinthackvalue, but rather has a specialvarinfo, which only exists in expressions very locally in the symb_locks analysis.