Modify Library Function Specification for assert to not dereference its argument #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I attempted to have a test for this, but working with //NOWARN as I wanted to did not help here, as the succeeding assert produces a "warning" in itself. |
sim642
approved these changes
Jul 12, 2022
Member
sim642
left a comment
sim642
left a comment
There was a problem hiding this comment.
This absolutely makes sense. I guess I must've still been in the mindset of the old specifications.
Other uses of r in these descriptions seem appropriate on actual pointer arguments.
Member
Might be able to work around this by disabling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like there was a mistake in the specification of the library function for
assertas it was marked to dereference its argument. This caused the warnings in #765.@sim642 does this fix makes sense like this? Are there other library functions that need to be fixed as well?
Closes #765