Skip to content

Fix get_ikind in eval_rv_ask_mustbeequal and is_safe_cast #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-schwarz merged 1 commit into from
Jul 21, 2022
Merged

Fix get_ikind in eval_rv_ask_mustbeequal and is_safe_cast #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/analyses/base.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ struct
in
let r =
match exp with
| BinOp (op,arg1,arg2,_) -> binop op arg1 arg2
| BinOp (op,arg1,arg2,_) when Cil.isIntegralType (Cilfacade.typeOf exp) -> binop op arg1 arg2
| _ -> eval_next ()
in
if M.tracing then M.traceu "evalint" "base eval_rv_ask_mustbeequal %a -> %a\n" d_exp exp VD.pretty r;
Expand Down
5 changes: 3 additions & 2 deletions src/cdomains/valueDomain.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,9 @@ struct
| TInt (ik,_), TFloat (fk,_) (* does a1 fit into ik's range? *)
| TFloat (fk,_), TInt (ik,_) (* can a1 be represented as fk? *)
-> false (* TODO precision *)
| _ -> IntDomain.Size.is_cast_injective ~from_type:t1 ~to_type:t2 && bitsSizeOf t2 >= bitsSizeOf t1
(*| _ -> false*)
| (TInt _ | TEnum _ | TPtr _) , (TInt _ | TEnum _ | TPtr _) ->
IntDomain.Size.is_cast_injective ~from_type:t1 ~to_type:t2 && bitsSizeOf t2 >= bitsSizeOf t1
| _ -> false

let ptr_ikind () = match !upointType with TInt (ik,_) -> ik | _ -> assert false

Expand Down