First approximation of pthread_setspecific by escaping things reachable from the argument and invalidating all globals
#877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if program contains `pthread_setspecific`
29 tasks
sim642
reviewed
Nov 1, 2022
sim642
approved these changes
Nov 2, 2022
michael-schwarz
changed the title
sem.unknown_function.invalidate.globals is set if program contains pthread_setspecificpthread_setspecific by escaping things reachable from the argument and invalidating all globals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our analysis currently is sound here, as the second argument to the function is considered escaped, and treated flow-insensitively from there on. Also, it is invalidated when
sem.unknown_function.invalidate.globalsis set.Any later writes thus do not lead to the value being changed back from
Tand thus all writes through the pointer obtained back frompthread_getspecificare also accounted for.This adds an assert that fails if the code makes use of
pthread_setspecificand ``sem.unknown_function.invalidate.globals` is disabled, leading to unsound results.This a temporary measure before #876 is attacked.