Separate machdep-config.h for each architecture#195
Merged
Conversation
Member
Author
|
Ugh, it now correctly creates both machdeps again on my machine where I also have 32-bit available, but fails when one doesn't. |
sim642
added a commit
to sim642/opam-repository
that referenced
this pull request
Sep 9, 2025
CHANGES: * Fix 32bit `Machdep` generation on 64bit host (goblint/cil#195).
mseri
added a commit
to ocaml/opam-repository
that referenced
this pull request
Oct 23, 2025
* [new release] goblint-cil (2.0.8) CHANGES: * Fix 32bit `Machdep` generation on 64bit host (goblint/cil#195). * goblint-cil.2.0.8: exclude arm64 debian-13 from with-test Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk> * goblint-cil.2.0.8: fix freebsd x-ci-accept-failures * Update packages/goblint-cil/goblint-cil.2.0.8/opam Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk> * Update packages/goblint-cil/goblint-cil.2.0.8/opam Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk> * Update packages/goblint-cil/goblint-cil.2.0.8/opam Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk> * Update packages/goblint-cil/goblint-cil.2.0.8/opam --------- Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk> Co-authored-by: Marcello Seri <mseri@users.noreply.github.com> Co-authored-by: Raphaël Proust <raphael-proust@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #193 after which Goblint started erroring on 32-bit SV-COMP tasks with
The problem is that
_Float16is available on 64-bit, but not 32-bit, so separate headers are needed. Otherwise the compilation of 32-bit machdep generation fails.The headers should've been separate from the beginning. It's surprising that nothing broke before.