Skip to content

Optimize hasAttribute to avoid unnecessary list allocation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sim642 merged 3 commits into from
Mar 24, 2026
Merged

Optimize hasAttribute to avoid unnecessary list allocation #222

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef8a0c9
Initial plan
Copilot Mar 19, 2026
c58bd38
Optimize hasAttribute to use List.exists instead of filterAttributes
Copilot Mar 19, 2026
01006d8
Remove obsolete sm comment before hasAttribute
Copilot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cil.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,7 +1427,7 @@ and filterAttributes (s: string) (al: attribute list) : attribute list =

(* sm: *)
Comment thread
michael-schwarz marked this conversation as resolved.
Outdated
let hasAttribute s al =
(filterAttributes s al <> [])
List.exists (fun (Attr(an, _)) -> an = s) al


type attributeClass =
Expand Down
Loading