refactor: move error templates to internal/templates#2418
Merged
paganotoni merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
Move error page templates from root to internal/templates/ and co-locate the embed variables in errors.go where they're used. Changes: - Moved error.dev.html, error.prod.html, notfound.prod.html to internal/templates/ - Deleted error_templates.go - Added embed directives directly in errors.go where the variables are used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move error page templates from root to internal/templates/ and co-locate the embed variables in errors.go where they're used.
Changes
error.dev.html,error.prod.html,notfound.prod.htmlfrom root tointernal/templates/error_templates.goerrors.gowhere the variables are usedRationale
This co-locates the templates with the code that uses them, following Go best practices for internal packages. It also cleans up the root directory by moving implementation details to an internal package.
Verification
go build ./...//go:embeddirectives