Skip to content

chore: update dependency download mirrors to reliable sources#46

Merged
d0wn3d merged 1 commit into
gobytecoin:developfrom
d0wn3d:depends-links
Mar 27, 2026
Merged

chore: update dependency download mirrors to reliable sources#46
d0wn3d merged 1 commit into
gobytecoin:developfrom
d0wn3d:depends-links

Conversation

@d0wn3d
Copy link
Copy Markdown
Collaborator

@d0wn3d d0wn3d commented Mar 27, 2026

Issue being fixed or feature implemented

Update download URLs for boost, expat, gmp, qrencode, and zlib packages to use more reliable and maintained sources, replacing deprecated or unstable mirrors (bintray, sourceforge, etc.) with GitHub releases, GNU FTP, and official archives.

What was done?

Mirror links updated for the following packages:

  • boost: Changed from https://dl.bintray.com/boostorg/release/1.64.0/source/ to https://archives.boost.io/release/1.64.0/source/

    • Normalized version format from 1_64_0 to 1.64.0
    • Updated file name to use version substitution
  • expat: Changed from https://downloads.sourceforge.net/project/expat/expat/2.2.1 to https://github.com/libexpat/libexpat/releases/download/R_2_2_1/

  • gmp: Changed from https://gmplib.org/download/gmp to https://ftp.gnu.org/gnu/gmp

  • zlib: Changed from http://www.zlib.net to https://www.zlib.net/fossils/ (HTTPS and specific version archive)

How Has This Been Tested?

The changes were tested by running the following commands inside the /depends/ folder:

  • Download for all platforms (macOS, Linux, Windows):

    make download
  • Verify existing downloads:

    make check-sources

Test Results:
All packages downloaded successfully and SHA256 checksums verified:

  • ✅ boost 1.64.0 - Downloaded and verified
  • ✅ expat 2.2.1 - Downloaded and verified
  • ✅ gmp 6.1.2 - Downloaded and verified
  • ✅ zlib 1.2.11 - Downloaded and verified
  • ✅ All other dependencies (openssl, libevent, zeromq, protobuf, qt, bdb, miniupnpc, etc.)

Breaking Changes

None - All SHA256 hashes remain valid as the files themselves have not changed, only the download sources.

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Summary by CodeRabbit

  • Chores
    • Updated download sources and archive naming/version formatting for several third‑party libraries (Boost, Expat, GMP, Zlib) to use updated upstream locations and consistent version syntax.
  • Bug Fixes
    • Corrected QRencode configure options to remove a malformed option and ensure proper configure behavior.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a9c20d38-ea99-4f07-9c39-8b5aac491b30

📥 Commits

Reviewing files that changed from the base of the PR and between b840ab4 and 5cff21f.

📒 Files selected for processing (5)
  • depends/packages/boost.mk
  • depends/packages/expat.mk
  • depends/packages/gmp.mk
  • depends/packages/qrencode.mk
  • depends/packages/zlib.mk
✅ Files skipped from review due to trivial changes (4)
  • depends/packages/gmp.mk
  • depends/packages/zlib.mk
  • depends/packages/expat.mk
  • depends/packages/boost.mk
🚧 Files skipped from review as they are similar to previous changes (1)
  • depends/packages/qrencode.mk

📝 Walkthrough

Walkthrough

Updated download sources and version metadata for five dependency packages. Boost, Expat, GMP, and Zlib now point to different stable mirrors; Boost's version format changed to dotted form. Qrencode had a command-line option spacing correction.

Changes

Cohort / File(s) Summary
Boost
depends/packages/boost.mk
Changed boost_version from 1_64_0 to 1.64.0, switched boost_download_path to https://archives.boost.io/release/$($(boost)_version)/source/, and adjusted archive filename construction to boost_$(subst .,_,$($(package)_version)).tar.bz2.
Expat
depends/packages/expat.mk
Switched expat download path from SourceForge to GitHub Releases: https://github.com/libexpat/libexpat/releases/download/R_$(subst .,_,$($(expat)_version))/.
GMP
depends/packages/gmp.mk
Updated GMP download base from https://gmplib.org/download/gmp to https://ftp.gnu.org/gnu/gmp.
Zlib
depends/packages/zlib.mk
Changed zlib download path from http://www.zlib.net to https://www.zlib.net/fossils/. File name and SHA256 unchanged.
Qrencode
depends/packages/qrencode.mk
Fixed qrencode configure options spacing/order: --disable-shared --without-tools --disable-sdltest (was --disable-shared -without-tools --disable-sdltest).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I nibbled URLs and made them neat,

dots for Boost and mirrors complete,
Expat hopped to GitHub's door,
GMP and zlib found new shore,
qrencode's flags now step in beat.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: update dependency download mirrors to reliable sources' accurately and clearly summarizes the main objective of the pull request—updating download URLs for multiple dependency packages to more stable sources.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Update download URLs for boost, expat, gmp, and zlib packages
to use more reliable and maintained sources, replacing deprecated or
unstable mirrors (bintray, sourceforge, etc.) with GitHub releases,
GNU FTP, and official archives.
@d0wn3d d0wn3d merged commit 947425b into gobytecoin:develop Mar 27, 2026
13 of 19 checks passed
@d0wn3d d0wn3d deleted the depends-links branch March 27, 2026 23:56
@d0wn3d d0wn3d added this to the 16.2.2 milestone Mar 29, 2026
d0wn3d added a commit that referenced this pull request Mar 31, 2026
534be8a chore: update testnet seeds (D0WN3D)
4bd9935 chore: update GPG key (D0WN3D)
4e0dc56 chore: update docs inside /doc/ (Antonio Moratti)
bde5c7d chore: add release nodes template (Antonio Moratti)
9e69306 chore: Add SECURITY.md (Antonio Moratti)
b6e1a70 chore: Add issues templates (Antonio Moratti)
f6a8c9d fix: reset testnet -- new genesis block (Antonio Moratti)
677bccb fix: remove LLMQ_5_60 and use LLMQ_50_60 for testnet (Antonio Moratti)
43672e2 fix(llmq): guard ProcessCommitment against unregistered LLMQ types (Antonio Moratti)
a74736f fix(llmq): validate null commitments before checking LLMQ type registration (Antonio Moratti)
743c51f fix: Re-enable BIP34 height check and correct BIP34Height value (Antonio Moratti)
7b18330 chore(depends): update dependency download mirrors to reliable sources (Antonio Moratti)
263a25a chore: update copyright year in configure.ac (Antonio Moratti)

Pull request description:

  ## Backport

  Cherry-picks of #46, #47, #49, and #50 into `v0.16.2.x` for v0.16.2.2

  Extra cherry-picked commits:
  263a25a [chore: update copyright year in configure.ac](263a25a)
  4c8df90 [chore: Add issues templates](4c8df90)
  bdc1f02 [chore: Add SECURITY.md](bdc1f02)
  c8a7baa [chore: add release nodes template](c8a7baa)
  719796f [chore: update docs inside /doc/](719796f)
  4bd9935 [chore: update GPG key](4bd9935)
  534be8a [chore: update testnet seeds](534be8a)

  ### Included

  - #46 — `chore: update dependency download mirrors to reliable sources`
  - #47 — `fix: Re-enable BIP34 height check and correct BIP34Height value`
  - #49 — `fix: validate null commitments before LLMQ type registration check`
  - #50 — `fix: remove LLMQ_5_60 and use LLMQ_50_60 for testnet`
  - #52 — `fix: restart testnet -- new genesis block`

  <!-- This is an auto-generated comment: release notes by coderabbit.ai -->
  ## Summary by CodeRabbit

  * **Chores**
    * Updated copyright year to 2026
    * Updated several third‑party package download sources, versions, and metadata

  * **Bug Fixes**
    * Stricter coinbase block-height validation to reject malformed blocks
    * Improved quorum/consensus handling to avoid runtime errors and tighten commitment verification
    * Removed a deprecated quorum type and adjusted quorum mappings

  * **Network**
    * Updated consensus activation parameters, genesis checkpoints, and defaults

  * **Documentation**
    * Added security policy, issue templates, operational guides, and a release‑notes template
  <!-- end of auto-generated comment: release notes by coderabbit.ai -->

Tree-SHA512: b1027831d259d511fb7e4d33cf50048d54e5a0308d93d7d90909818b7ab3eb7ed38dbcd436a019285b0d8442e496cc1a263e3a636a03d74dfa268ec8dd99a63a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant