chore: update dependency download mirrors to reliable sources#46
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated download sources and version metadata for five dependency packages. Boost, Expat, GMP, and Zlib now point to different stable mirrors; Boost's version format changed to dotted form. Qrencode had a command-line option spacing correction. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Update download URLs for boost, expat, gmp, and zlib packages to use more reliable and maintained sources, replacing deprecated or unstable mirrors (bintray, sourceforge, etc.) with GitHub releases, GNU FTP, and official archives.
534be8a chore: update testnet seeds (D0WN3D) 4bd9935 chore: update GPG key (D0WN3D) 4e0dc56 chore: update docs inside /doc/ (Antonio Moratti) bde5c7d chore: add release nodes template (Antonio Moratti) 9e69306 chore: Add SECURITY.md (Antonio Moratti) b6e1a70 chore: Add issues templates (Antonio Moratti) f6a8c9d fix: reset testnet -- new genesis block (Antonio Moratti) 677bccb fix: remove LLMQ_5_60 and use LLMQ_50_60 for testnet (Antonio Moratti) 43672e2 fix(llmq): guard ProcessCommitment against unregistered LLMQ types (Antonio Moratti) a74736f fix(llmq): validate null commitments before checking LLMQ type registration (Antonio Moratti) 743c51f fix: Re-enable BIP34 height check and correct BIP34Height value (Antonio Moratti) 7b18330 chore(depends): update dependency download mirrors to reliable sources (Antonio Moratti) 263a25a chore: update copyright year in configure.ac (Antonio Moratti) Pull request description: ## Backport Cherry-picks of #46, #47, #49, and #50 into `v0.16.2.x` for v0.16.2.2 Extra cherry-picked commits: 263a25a [chore: update copyright year in configure.ac](263a25a) 4c8df90 [chore: Add issues templates](4c8df90) bdc1f02 [chore: Add SECURITY.md](bdc1f02) c8a7baa [chore: add release nodes template](c8a7baa) 719796f [chore: update docs inside /doc/](719796f) 4bd9935 [chore: update GPG key](4bd9935) 534be8a [chore: update testnet seeds](534be8a) ### Included - #46 — `chore: update dependency download mirrors to reliable sources` - #47 — `fix: Re-enable BIP34 height check and correct BIP34Height value` - #49 — `fix: validate null commitments before LLMQ type registration check` - #50 — `fix: remove LLMQ_5_60 and use LLMQ_50_60 for testnet` - #52 — `fix: restart testnet -- new genesis block` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated copyright year to 2026 * Updated several third‑party package download sources, versions, and metadata * **Bug Fixes** * Stricter coinbase block-height validation to reject malformed blocks * Improved quorum/consensus handling to avoid runtime errors and tighten commitment verification * Removed a deprecated quorum type and adjusted quorum mappings * **Network** * Updated consensus activation parameters, genesis checkpoints, and defaults * **Documentation** * Added security policy, issue templates, operational guides, and a release‑notes template <!-- end of auto-generated comment: release notes by coderabbit.ai --> Tree-SHA512: b1027831d259d511fb7e4d33cf50048d54e5a0308d93d7d90909818b7ab3eb7ed38dbcd436a019285b0d8442e496cc1a263e3a636a03d74dfa268ec8dd99a63a
Issue being fixed or feature implemented
Update download URLs for boost, expat, gmp, qrencode, and zlib packages to use more reliable and maintained sources, replacing deprecated or unstable mirrors (bintray, sourceforge, etc.) with GitHub releases, GNU FTP, and official archives.
What was done?
Mirror links updated for the following packages:
boost: Changed from
https://dl.bintray.com/boostorg/release/1.64.0/source/tohttps://archives.boost.io/release/1.64.0/source/1_64_0to1.64.0expat: Changed from
https://downloads.sourceforge.net/project/expat/expat/2.2.1tohttps://github.com/libexpat/libexpat/releases/download/R_2_2_1/gmp: Changed from
https://gmplib.org/download/gmptohttps://ftp.gnu.org/gnu/gmpzlib: Changed from
http://www.zlib.nettohttps://www.zlib.net/fossils/(HTTPS and specific version archive)How Has This Been Tested?
The changes were tested by running the following commands inside the
/depends/folder:Download for all platforms (macOS, Linux, Windows):
Verify existing downloads:
Test Results:
All packages downloaded successfully and SHA256 checksums verified:
Breaking Changes
None - All SHA256 hashes remain valid as the files themselves have not changed, only the download sources.
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Summary by CodeRabbit