Skip to content

Conversation

@dkotter
Copy link
Collaborator

@dkotter dkotter commented Mar 18, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

In order to help protect against compromised actions, instead of including actions based on their major version (like v4), this PR switches all the actions we use to pull based on the commit hash from the latest release.

While this does impact maintenance a bit going forward, it ensures that we we're always using actions that we (hopefully) trust and if an action gets compromised (which happens) we don't have to worry that we're using a compromised action. This also goes along with what GitHub suggests.

Steps to test the changes in this Pull Request:

Ensure all our workflows still run as expected

Changelog entry

Dev - Update all third-party actions our workflows rely on to use versions based on specific commit hashes

Copy link
Collaborator

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iamdharmesh iamdharmesh moved this from Code Review (10up) to UAT in 10up GC WooCommerce Project Mar 24, 2025
@dkotter dkotter modified the milestones: Future Release, 2.9.3 Mar 24, 2025
@dkotter dkotter merged commit 2414a17 into develop Mar 24, 2025
12 of 14 checks passed
@dkotter dkotter deleted the update/pin-workflow-actions branch March 24, 2025 13:17
@vikrampm1 vikrampm1 moved this from Merged to Done in 10up GC WooCommerce Project Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants