Skip to content

Ensure all supported SEPA zone countries are included. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

iamdharmesh
Copy link
Collaborator

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR adds the following missing countries from the SEPA Zone, which are supported by GoCardless as mentioned here.

  • Andorra
  • Aland Islands
  • French Guiana
  • Guadeloupe
  • Martinique
  • Mayotte
  • Saint Barthélemy
  • Saint Martin (French part)
  • Réunion
  • Saint Pierre and Miquelon
  • Vatican City State
  • Gibraltar
  • Guernsey
  • Jersey
  • Isle of Man

Note

I couldn't find "Azores and Madeira" (parts of Portugal) and "Canary Islands and Ceuta and Melilla" (parts of Spain) in WooCommerce’s or GoCardless’ country dropdowns. These appear to be regions under their respective countries, so they seem to be already covered.

Closes #54

Steps to test the changes in this Pull Request:

Verify that the GoCardless Payment Gateway is available for the newly added countries and works as expected.

Changelog entry

Fix - Ensure all supported SEPA zone countries are included.

- Andorra
- Aland Islands
- French Guiana
- Guadeloupe
- Martinique
- Mayotte
- Saint Barthélemy
- Saint Martin (French part)
- Réunion
- Saint Pierre and Miquelon
- Vatican City State
- Gibraltar
- Guernsey
- Jersey
- Isle of Man
@iamdharmesh iamdharmesh self-assigned this Apr 23, 2025
@iamdharmesh iamdharmesh requested a review from dkotter April 23, 2025 07:36
@iamdharmesh iamdharmesh added this to the Future Release milestone Apr 23, 2025
dkotter
dkotter previously approved these changes Apr 23, 2025
@qasumitbagthariya
Copy link
Collaborator

QA Update ✅


I have verified this PR in the fix/54 branch, which has been fixed and is functioning as intended.

I tested the following on this branch:

  • Supported SEPA zone countries
Screen.Recording.2025-05-12.at.1.41.38.PM.mov
Screen.Recording.2025-05-12.at.1.40.20.PM.mov

Testing Environment

  • WordPress: 6.8
  • Theme: Twenty Twenty-Four 1.3
  • WooCommerce - 9.8.3
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: fix/54

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for code review (Woo)
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

@iamdharmesh iamdharmesh dismissed stale reviews from dkotter and qasumitbagthariya via 2ac0601 May 12, 2025 09:55
@iamdharmesh
Copy link
Collaborator Author

@qasumitbagthariya Failing E2E tests are started passing now. 1 test is failing due to an issue with admin notices being suppressed on the payment gateway settings page as mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all the Eurozone countries are supported
4 participants