Ensure our final release doesn't contain itself #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it, as it will be archived by our action-wordpress-plugin-build-zip workflow
|
[ERROR] Could not find Woo Extension with slug woocommerce-gateway-gocardless. |
iamdharmesh
approved these changes
Oct 8, 2025
Collaborator
iamdharmesh
left a comment
iamdharmesh
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this @dkotter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
In #68 we changed the way we build our release zip. In testing out the final release zip prior to doing an actual release today, ran into an issue where I found that final release contained itself and was causing issues when trying to activate the plugin in WordPress.
Looking closer at the changes we made in #68, we run
npm run buildwhich will build the plugin and then run our archive command. We then run the10up/action-wordpress-plugin-build-zipworkflow which will also produce a zip. This results with a zip within a zip, which causes problems.This PR attempts to fix that by switching to
npm run build:webpackwhich will just run our build steps not the archive steps.Steps to test the changes in this Pull Request:
Ensure the QIT build step and E2E build step pass, as both use the Generate Zip action.
Changelog entry
n/a