Skip to content

fix: consider maps and arrays with length 0 empty #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
secDre4mer wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

fix: consider maps and arrays with length 0 empty #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions internal/encoder/encoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,9 @@ func AppendIndent(ctx *RuntimeContext, b []byte, indent uint32) []byte {
return b
}

// IsNilForMarshaler returns whether an element should be omitted if omitempty is set.
// According to encoding/json, the following values are considered empty:
// false, 0, a nil pointer, a nil interface value, and any array, slice, map, or string of length zero.
func IsNilForMarshaler(v interface{}) bool {
rv := reflect.ValueOf(v)
switch rv.Kind() {
Expand All @@ -590,11 +593,9 @@ func IsNilForMarshaler(v interface{}) bool {
return rv.Uint() == 0
case reflect.Float32, reflect.Float64:
return math.Float64bits(rv.Float()) == 0
case reflect.Interface, reflect.Map, reflect.Ptr, reflect.Func:
case reflect.Interface, reflect.Ptr, reflect.Func:
return rv.IsNil()
case reflect.Slice:
return rv.IsNil() || rv.Len() == 0
case reflect.String:
case reflect.Slice, reflect.Map, reflect.String, reflect.Array:
return rv.Len() == 0
}
return false
Expand Down