feat: add global OmitEmpty encoding option
#691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2025
Thanks for an amazing project! Go ecosystem struggle (e.g. GoogleCloudPlatform/prometheus-engine#1629) with 3P types that lack a good marshalling practices. Many project have config structs only designed for parsing. See goccy#306 for the detailed motivation. Fixes: goccy#306 The feature mechanism is simple -- we ignore struct tag setting for omitempty. We assume it's always 'omitempty' if yaml.OmitEmpty() setting is set. Signed-off-by: bwplotka <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
==========================================
+ Coverage 77.87% 77.89% +0.01%
==========================================
Files 22 22
Lines 7960 7965 +5
==========================================
+ Hits 6199 6204 +5
Misses 1348 1348
Partials 413 413 🚀 New features to boost your workflow:
|
Owner
|
Thank you for your great PR !!! LGTM 👍 |
bwplotka
commented
Apr 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for an amazing project! Go ecosystem struggle (e.g. GoogleCloudPlatform/prometheus-engine#1629) with 3P types that lack a good marshalling practices. Many projects have config structs only designed for parsing. See #306 for the detailed motivation.
Fixes: #306
The feature mechanism is simple -- we ignore struct tag setting for omitempty. We assume it's always 'omitempty' if yaml.OmitEmpty() setting is set.
I confirm: