-
-
Notifications
You must be signed in to change notification settings - Fork 206
feat: implement UnmarshalerError #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
p-sherratt
wants to merge
5
commits into
goccy:master
Choose a base branch
from
p-sherratt:add-unmarshaler-error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2531,6 +2531,9 @@ func TestUnmarshalablePtrString(t *testing.T) { | |
| type unmarshalableIntValue int | ||
|
|
||
| func (v *unmarshalableIntValue) UnmarshalYAML(raw []byte) error { | ||
| if string(raw) == "yamlerr" { | ||
| return yaml.Unmarshal(raw, (*int)(v)) | ||
| } | ||
| i, err := strconv.Atoi(string(raw)) | ||
| if err != nil { | ||
| return err | ||
|
|
@@ -2604,6 +2607,38 @@ func TestUnmarshalablePtrInt(t *testing.T) { | |
| }) | ||
| } | ||
|
|
||
| func TestUnmarshalableErrors(t *testing.T) { | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is only a test case for |
||
| t.Run("wrapped error", func(t *testing.T) { | ||
| t.Parallel() | ||
| var container unmarshalableIntContainer | ||
| err := yaml.Unmarshal([]byte(`value: atoierr`), &container) | ||
| if err == nil { | ||
| t.Fatal("expected to error") | ||
| } | ||
| var unmarshalerErr *errors.UnmarshalerError | ||
| if !errors.As(err, &unmarshalerErr) { | ||
| t.Fatalf("expected UnmarshalerError but got: %s", err) | ||
| } | ||
| expectedErr := `yaml_test.unmarshalableIntValue: strconv.Atoi: parsing "atoierr": invalid syntax` | ||
| if !strings.Contains(err.Error(), expectedErr) { | ||
| t.Fatalf("expected error message: %s to contain: %s", err.Error(), expectedErr) | ||
| } | ||
| }) | ||
|
|
||
| t.Run("nested yaml decode error", func(t *testing.T) { | ||
| t.Parallel() | ||
| var container unmarshalableIntContainer | ||
| err := yaml.Unmarshal([]byte(`value: yamlerr`), &container) | ||
| if err == nil { | ||
| t.Fatal("expected to error") | ||
| } | ||
| expectedErr := `cannot unmarshal into Go value of type yaml_test.unmarshalableIntValue: cannot unmarshal string into Go value of type int` | ||
| if !strings.Contains(err.Error(), expectedErr) { | ||
| t.Fatalf("expected error message: %s to contain: %s", err.Error(), expectedErr) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| type literalContainer struct { | ||
| v string | ||
| } | ||
|
|
@@ -3206,6 +3241,9 @@ type unmarshableMapKey struct { | |
| } | ||
|
|
||
| func (mk *unmarshableMapKey) UnmarshalYAML(b []byte) error { | ||
| if string(b) == "errkey" { | ||
| return errors.New("invalid map key") | ||
| } | ||
| mk.Key = string(b) | ||
| return nil | ||
| } | ||
|
|
@@ -3401,6 +3439,15 @@ func TestMapKeyCustomUnmarshaler(t *testing.T) { | |
| if val != "value" { | ||
| t.Fatalf("expected to have value \"value\", but got %q", val) | ||
| } | ||
|
|
||
| expectErr := "invalid map key" | ||
| err := yaml.Unmarshal([]byte(`errkey: value`), &m) | ||
| if err == nil { | ||
| t.Fatal("expected error but got nil") | ||
| } | ||
| if !strings.Contains(err.Error(), expectErr) { | ||
| t.Fatalf("error message %q should contain %q", err.Error(), expectErr) | ||
| } | ||
| } | ||
|
|
||
| type bytesUnmershalerWithMapAlias struct{} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will stop working if the
erris wrapped somewhere. Why did you change the sequence using As ?