Allow private VideoPress videos to play when the URL is pasted on the Video Embed URL.#2566
Merged
ideadude merged 5 commits intogocodebox:devfrom Jul 4, 2024
Merged
Conversation
actuallyakash
changed the title
brianhogg
reviewed
Jun 11, 2024
| } | ||
| } | ||
|
|
||
| return null; |
Contributor
There was a problem hiding this comment.
Don't need to return null here, could just return nothing.
brianhogg
reviewed
Jun 11, 2024
| // VideoPress Provider. | ||
| if ( is_plugin_active( 'jetpack-videopress/jetpack-videopress.php' ) ) { | ||
| if ( strpos( $host, 'videopress.com' ) !== false || strpos( $host, 'video.wordpress.com' ) !== false ) { | ||
| wp_enqueue_script( 'videopress-token-bridge', plugins_url() . '/jetpack-videopress/jetpack_vendor/automattic/jetpack-videopress/src/../build/lib/token-bridge.js', array(), llms()->version, true ); |
Contributor
There was a problem hiding this comment.
I'm not exactly sure why we need to specify the complete URL here, but it works!
brianhogg
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now private VideoPress videos can be played when used in Video Embed URL in a lesson/course.
Fixes #2533
How has this been tested?
Manually.
Types of changes
Bug fix.
Checklist: