Conversation
brianhogg
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A user reported this issue in the 7.7 update on wp .org here: https://wordpress.org/support/topic/preg_replace-passing-null-to-parameter-3-subject/#post-17939000
Our code like
echo wp_kses_post( paginate_links( ... ) );would sometimes return warnings if the results of the paginate_links call was empty. This is because wp_kses_post called wp_kses, which calls preg_replace at some point down the line, which expects the content being replaced is not empty.We now set a variable using paginate_links, then check if that result is non empty before echoing and calling wp_kses_post.
How has this been tested?
Manually loading the memberships and notifications pages of the student dashboard with both pagination and not.
Checklist: