Updating permissions checks in the AJAX handler.#2895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added additional permissions checks to callback functions triggered via AJAX where appropriate.
We also removed some deprecated methods of the LLMS_AJAX_Handler class, including:
We also added the function
llms_current_user_can_edit_product()which takes a product_id (for a course or membership) and returns if the current user can edit that course or membership. This makes the permissions checks for products more clear.How has this been tested?
We've created AJAX calls for each method and confirmed the new or existing permissions checks keep unwanted actions from occuring.
We also tested across the whole application to make sure these changes aren't affecting legitimate use of the software.
Checklist: