Skip to content

Switch to recommended mb_encode_numericentity() #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianhogg merged 2 commits into from
Mar 12, 2026
Merged

Switch to recommended mb_encode_numericentity() #3106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fb33f6
Switch to recommended mb_encode_numericentity().
brianhogg Mar 10, 2026
9494cea
Changelog
brianhogg Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changelogs/fix_mb_convert_encoding.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
significance: minor
type: fixed
links:
- "#2672"
entry: Removes use of deprecated mb_convert_encoding().
6 changes: 4 additions & 2 deletions includes/class-llms-dom-document.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,16 @@ public function dom() {
}

/**
* Load the HTML string in the DOMDocument using mb_convert_econding
* Load the HTML string in the DOMDocument using mb_encode_numericentity
*
* @since 4.13.0
* @since [version] Use `mb_encode_numericentity()` instead of deprecated `mb_convert_encoding()` with 'HTML-ENTITIES'.
*
* @return void
*/
private function load_with_mb_convert_encoding() {
if ( ! $this->dom->loadHTML( mb_convert_encoding( $this->source, 'HTML-ENTITIES', 'UTF-8' ) ) ) {
$html = mb_encode_numericentity( $this->source, array( 0x80, 0x10FFFF, 0, 0x1FFFFF ), 'UTF-8' );
if ( ! $this->dom->loadHTML( $html ) ) {
$this->error = new WP_Error( 'llms-dom-document-error', __( 'DOMDocument XML Error encountered.', 'lifterlms' ), libxml_get_errors() );
}
}
Expand Down
Loading