Add the user to the order status change note - #3338
Open
robindevitt wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the user to the order status change note.
Fixes #3039
How has this been tested?
Manually and reviewed via the order edit screen.
Screenshots
Types of changes
The function
add_notehas a second parameteradded_by_userwhich by default isfalse. So this change is setting theadded_by_userparameter to true so the user details are shown in the notes.By default it renders the users
display_name. Referenced the screenshot for these below notes.Note 1: Currently the note author was set to show as
LifterLMSNote 2: Showing the status update made by me with my display name being shown.
Note 3: I changed my display name and then changed the order status, to confirm it shows my updated display name.
Checklist: