cleanup useless null pointer checks for nodeInfo.Node() - #52
Open
NoicFank wants to merge 1 commit into
Open
Conversation
NoicFank
force-pushed
the
cleanup-scheduler-node-must-not-nil
branch
from
October 20, 2023 06:59
5165772 to
3cc88df
Compare
Author
|
/assign @qmhu |
|
🎉 Successfully Build Images. Docker RegistryOverview: https://hub.docker.com/u/gocrane
Coding RegistryOverview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Ghcr RegistryOverview: https://github.com/orgs/gocrane/packages?repo_name=crane
|
qmhu
reviewed
Oct 20, 2023
qmhu
left a comment
Member
There was a problem hiding this comment.
I think NPE checking is just fine here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodeInfo.Node() will never be nil, thus removing those validations.
For k/k, Null pointer check about nodeInfo.Node() from snapshot is removed for in-tree plugins, pls see following PR.
kubernetes/kubernetes#117834