-
Notifications
You must be signed in to change notification settings - Fork 1
Introduce super linter #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces automated linting using GitHub's super-linter to enforce code quality standards across the repository. The implementation focuses on markdown and YAML validation, which aligns well with the repository's design-first, documentation-heavy approach for the Agent Name Service Registry.
Key Changes:
- Added GitHub Actions workflow for automated linting on push and pull request events
- Configured super-linter v8.2.1 with incremental validation (changed files only)
- Enabled markdown and YAML linting with GitHub Actions status reporting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| on: | ||
| push: | ||
|
|
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When VALIDATE_ALL_CODEBASE: false is set (line 38), super-linter only lints changed files by comparing against the default branch. However, with these unfiltered triggers, the workflow runs on all push and pull_request events, including pushes to the main branch itself. When triggered by a push to main, there may not be a proper comparison point, which could cause the linter to either fail or unexpectedly lint all files.
Consider adding branch filters to prevent running on pushes to the default branch:
on:
push:
branches-ignore:
- main
pull_request:Alternatively, if you want to lint all files on main, you could use a conditional VALIDATE_ALL_CODEBASE setting based on the branch.
| branches-ignore: | |
| - main |
No description provided.