Validate call params for gd_self virtual methods. - #1382
Merged
Bromeon merged 1 commit intoOct 25, 2025
Merged
Conversation
Yarwin
force-pushed
the
bugfix/validate-call-params-for-gd-self-methods
branch
from
October 25, 2025 06:17
0f16afe to
0102c26
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1382 |
Yarwin
force-pushed
the
bugfix/validate-call-params-for-gd-self-methods
branch
from
October 25, 2025 06:37
0102c26 to
a88358e
Compare
Bromeon
reviewed
Oct 25, 2025
| /// For example `::godot::private::virtuals::Node::Sig_physics_process` is `(f64, )`, | ||
| /// thus `let params: ::godot::private::virtuals::Node::Sig_physics_process = ();` | ||
| /// will not compile. | ||
| fn make_tuple_sig_annotation(trait_base_class: &Ident, method_name: &Ident) -> TokenStream { |
Member
There was a problem hiding this comment.
Suggested change
| fn make_tuple_sig_annotation(trait_base_class: &Ident, method_name: &Ident) -> TokenStream { | |
| fn make_sig_tuple_annotation(trait_base_class: &Ident, method_name: &Ident) -> TokenStream { |
To be consistent with variable name.
Yarwin
force-pushed
the
bugfix/validate-call-params-for-gd-self-methods
branch
from
October 25, 2025 09:18
a88358e to
81dfc9a
Compare
Bromeon
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1374
Before this PR, following code:
did compile without issues, now it throws following errors: