Fix async SignalFuture panic when object is freed before exit flag - #1648
Merged
Conversation
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1648 |
…t flag Previously, the engine-exiting flag was only checked when the signal resolver was dropped. But during a real shutdown, the signal object is often freed before that flag is set. The resolver then marks the future as dead and wakes it, so the drop-time check is too late, and the next poll panics with "the signal object of a SignalFuture was freed". Now the flag is also checked at poll time: a dead `SignalFuture` polled while the engine is exiting parks silently (and is dropped during cleanup) instead of panicking. `FallibleSignalFuture` is unchanged and still resolves to an error. Adds an integration test for the freed-before-flag ordering.
Bromeon
force-pushed
the
bugfix/async-shutdown-poll-panic
branch
from
June 28, 2026 08:27
999a419 to
73fed1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the engine-exiting flag was only checked when the signal resolver was dropped. But during a real shutdown, the signal object is often freed before that flag is set. The resolver then marks the future as dead and wakes it, so the drop-time check is too late, and the next poll panics with "the signal object of a SignalFuture was freed".
Now the flag is also checked at poll time: a dead
SignalFuturepolled while the engine is exiting parks silently (and is dropped during cleanup) instead of panicking.FallibleSignalFutureis unchanged and still resolves to an error.Adds an integration test for the freed-before-flag ordering.
Closes #1624.