Fix api-custom build when prebuilt lags detected Godot version - #1649
Merged
Conversation
With `api-custom`, godot-rust reuses the shipped prebuilt `gdextension_interface.json`, unless the Godot binary is newer than the prebuilt covers. That check used the hand-maintained `LATEST_API_VERSION` constant, which can be ahead of the currently used default version (e.g. latest 4.7, default 4.6). A 4.7 binary then got the stale 4.6 interface, missing functions like `classdb_construct_object3`, resulting in a not very helpful `no field ...` error message.
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1649 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
api-custom, godot-rust reuses the shipped prebuiltgdextension_interface.jsonunless the Godot binary is newer than the prebuilt covers. That check used the hand-maintainedLATEST_API_VERSIONconstant, which can run ahead of the currently used default version (e.g. latest 4.7, default 4.6). A 4.7 binary then got the stale 4.6 interface, missing functions likeclassdb_construct_object3, resulting in a not very helpfulno field ...error message.This instead reads the prebuilt JSON itself and parses the maximum value of the
sincefields, dumping from the binary whenever it is ahead. Also adds a codegen guard that fails early when a required interface function is missing for the detected API version.Fixes #1646.