Name virtual-callback layers after user-facing I* virtuals - #1662
Merged
Conversation
Bromeon
added
c: ffi
Bromeon
force-pushed
the
mtnc/callback-names
branch
from
July 21, 2026 20:30
0272e05 to
e9c23dd
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1662 |
Bromeon
force-pushed
the
mtnc/callback-names
branch
from
July 21, 2026 20:39
e9c23dd to
d59dd51
Compare
Panic messages still reported old names, e.g. `on_get` surfaced as `MyClass::get_property()`. Now uses same terms across 7 layers: * `handle_on_set` (macro codegen) * `Decls::on_set_impl` (macro codegen) * shard builder `with_on_set` * `ITraitImpl::user_set_fn` field * `set` (extern "C" callback) * callback panic message * `T::__godot_on_set` capability trait method The `extern "C"` callbacks now match their GDExtension slots exactly: `set_property` -> `set`, `get_property` -> `get`, `on_notification` -> `notification`.
Bromeon
force-pushed
the
mtnc/callback-names
branch
from
July 21, 2026 21:24
d59dd51 to
fec190a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panic messages still reported old names, e.g.
on_getsurfaced asMyClass::get_property(). And there was quite a big inconsistency on how the same thing was named, partly due to renames in #1555, partly due to 1 Rust function mapping to 2 Godot ones, partly because naming simply wasn't aligned at the time.Now uses same terms across 7 layers:
handle_on_set(macro codegen)Decls::on_set_impl(macro codegen)with_on_setITraitImpl::user_set_fnfieldset(extern "C" callback)T::__godot_on_setcapability trait methodThe
extern "C"callbacks now match their GDExtension slots exactly:set_property->set,get_property->get,on_notification->notification.