Ditch .framework folders and let the export plugin copy and sign .dylib files
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, I haven't been able to successfully export an iOS project so far, so I can't confirm whether it creates |
|
In that case we could either upgrade the export plugins to create the folders or keep the .framework folders and just get rid of the signing. |
|
If I'm seeing it correctly, you tested macOS export. I think only the iOS godot exporter upgrades to |
|
I tried my luck at exporting an iOS build but didn't get far. The macOS VM I'm running on my Proxmox server is very laggy. I'm going mental trying to make it work. It would be neat if someone could go metal instead - haha - and try exporting a project with the artifact for iOS and post the |
|
I'm on mac and I've been trying, but I'm not sure its possible without a dev account. Certainly complained every time so far. |
|
I tried exporting the project for iOS. It didn't succeed but there are interesting errors before the critical failure. Only happens with the GDExtension installed. Here are the full logs: https://pastebin.com/xBZru8VH. No mention of the extension's dylib. The dylibs should be processed in
|
|
Since bruvzg confirmed on RocketChat that the iOS exporter should convert the raw dylibs to frameworks we should keep pursuing this.
|
unvermuthet
force-pushed
the
ditch-frameworks
branch
2 times, most recently
from
af4753e to
8baa987
Compare
|
@dsnopek I remembered that you offered to test this so I've updated the PR description with better instructions. |
|
@dsnopek Do you think you have time to give it a go before the next GDExtension meeting? |
|
Sorry it took me so long to get to this! Re-learning and re-setting up all this stuff on MacOS is a very effective deterrent :-) To test, I...:
I then configured exports for both MacOS and iOS using all my Apple ID and code signing certificate junk. The short version: it seemed to work! Here's the verbose output from both export processes: Export log for MacOSExport log for iOSThe signing and notarizing (in the case of MacOS) and framework generation stuff in the logs all looks successful. I was able to run the exported project on my Mac Mini and on my iPhone 12, and it showed the extension in the label, so presumably it loaded fine. |
|
Thanks, @dsnopek! This is great news. Looks like it's being converted, copied, and given an extra signing! You could check the dylib location within the iOS I'll rebase this PR. |
unvermuthet
force-pushed
the
ditch-frameworks
branch
from
8baa987 to
883c029
Compare
unvermuthet
commented
Apr 6, 2025
unvermuthet
force-pushed
the
ditch-frameworks
branch
from
883c029 to
1661cf5
Compare
Ivorforce
approved these changes
Apr 6, 2025
unvermuthet
commented
Apr 6, 2025
As much as I could without a proper Mac. |
unvermuthet
force-pushed
the
ditch-frameworks
branch
from
1661cf5 to
51d35ff
Compare
Ivorforce
reviewed
Apr 6, 2025
Right, I forgot you don't have one. |
unvermuthet
force-pushed
the
ditch-frameworks
branch
from
51d35ff to
e4e73a2
Compare
Here's the contents of the |
Perfect, thank you! Looks good. |
|
This does look now like it's working as intended. Is this PR mergeable then? |
|
I'd say so! |
paddy-exe
approved these changes
Apr 9, 2025
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for the removal of
.frameworkfolders.At the last GDExtension meeting we discussed the possibility of ditching the use of framework folders for MacOS and iOS and letting Godot's export plugin handle the code signing. This simplifies the directory structure, the library paths in the
.gdextensionfile and thebuilds.ymlworkflow.MacOS and iOS binaries ...
.frameworkfoldersbuilds.ymlworkflowHere is how to test that the export plugin's codesigning of shared objects and conversion to frameworks on iOS is functional:
--verbose.gdextensionfor convenience, otherwise it's just the artifact (The CI should just do this...)Export with Debugenabled as the binaries for thereleasetag are referenced but not built.dylibfile is present inContents/Framework/Export with Debugenabled as the binaries for thereleasetag are referenced but not built.ipato.zip.dylibfile were placed in a.frameworkfolder under something like/Payload/Application.app/Contents/Framework/.frameworkfolders are a requirement for the App StoreSee @dsnopek's logs down below.