-
Notifications
You must be signed in to change notification settings - Fork 65
Add an example for using a build profile #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a4c8760
to
f9ce1cf
Compare
I like this type of thing, I recommend using a build profile a lot in the discord, so having it front and center for people to experiment with is a "show don't tell" move. |
f9ce1cf
to
de06052
Compare
I changed it from being passed by default with no disabled classes to having just a few classes enabled and marking it as an example to be adjusted and included. This was discussed and agreed upon in the GDExtension meeting on 1st April. @dsnopek was against adding a comment to the |
It's not my personal preference but I think it's fine :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely move this info to the docs, but we don't have it there yet. So I'm ok with it as-is.
I'm not sure I'd add the comment there like this, I think having the SConstruct
comment is good enough as long as the build profile is disabled by default. But it works for me.
de06052
to
06a136e
Compare
Merged. Thank you all! |
I suggest adding this file to hint at the fact that doing this is possible. Disabling unused classes can save a lot of time when compiling godot-cpp.
The included build profile has some example classes enabled. To make use of the feature, a user would discover the file, read the comment in the SConstruct, adjust the profile and uncomment the instruction.