Skip to content

Rename libraries, and add more to example.gdextension. #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

Ivorforce
Copy link
Member

@Ivorforce Ivorforce commented Apr 9, 2025

"Revival" of #55.

Now that .framework is gone, renames are simpler (and relevant) again:

  • Rename windows libraries to drop the lib prefix, as this is not customary on Windows.
    • This is already the case for release builds as the manual lib prefix was dropped with the latest PR.
  • Drop universal. suffix on macOS, as this is implied if there is no distinction between arches.
  • Add more targets for the .gdextension file, including web, more linux targets, and separate single and double builds.

This is pretty much the setup I use for NumDot right now.

@paddy-exe paddy-exe added the enhancement New feature or request label Apr 11, 2025
…tomary on Windows.

Drop `universal.` suffix on macOS, as this is implied if there is no distinction between arches.
Add more targets for the .gdextension file, including web, more linux targets, and separate single and double builds.
Copy link
Collaborator

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for taking in my feedback!

@paddy-exe paddy-exe merged commit 7ef3bea into godotengine:main Apr 11, 2025
23 checks passed
@Ivorforce Ivorforce deleted the unified-names branch April 11, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants