Skip to content

Add Sprite3D and AnimatedSprite3D demo #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

yuantianle
Copy link
Contributor

Finish demoing the project and implementing Sprite3D and AnimatedSprite3D. Also, provide game visual effects using shaders.

TODO: The link to the demo on the asset library in the README needs to be added.

Related to #1173

@yuantianle yuantianle force-pushed the Add-a-Sprite3D-demo branch from c3d074b to 91f0df4 Compare April 16, 2025 04:07
@yuantianle
Copy link
Contributor Author

@Calinou do you have any good ways to eliminate the format issue shown in https://github.com/godotengine/godot-demo-projects/actions/runs/14484485384/job/40627594851?pr=1191? Thanks!

@Calinou
Copy link
Member

Calinou commented Apr 16, 2025

@Calinou do you have any good ways to eliminate the format issue shown in godotengine/godot-demo-projects/actions/runs/14484485384/job/40627594851?pr=1191? Thanks!

There's trailing whitespace in the files. You can remove it by saving the impacted files with a text editor that has its "Trim Trailing Whitespace on Save" option enabled.

That said, I can handle this since there are many changes that need to be done before the demo can be merged.

@yuantianle
Copy link
Contributor Author

Thank you! Please let me know if you will need any help.

@yuantianle
Copy link
Contributor Author

@Calinou Just following up. Are there anything I can help for this PR? Thanks.

@Calinou Calinou force-pushed the Add-a-Sprite3D-demo branch from 91f0df4 to 2f319f6 Compare April 24, 2025 15:16
@Calinou
Copy link
Member

Calinou commented Apr 24, 2025

@Calinou Just following up. Are there anything I can help for this PR? Thanks.

I've applied changes to the demo to polish it up, it should be good to merge now.

Thanks a lot for submitting this demo 🙂

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Congratulations for your first merged pull request 🎉

@yuantianle
Copy link
Contributor Author

Thank you @Calinou !~

@Calinou Calinou force-pushed the Add-a-Sprite3D-demo branch 2 times, most recently from b114664 to 2d78dca Compare April 24, 2025 15:25
@Calinou Calinou force-pushed the Add-a-Sprite3D-demo branch from 2d78dca to 2f88691 Compare April 24, 2025 15:35
@Calinou Calinou merged commit 90f3091 into godotengine:master Apr 24, 2025
1 check passed
@yuantianle yuantianle deleted the Add-a-Sprite3D-demo branch April 24, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants