-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Sprite3D and AnimatedSprite3D demo #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c3d074b
to
91f0df4
Compare
@Calinou do you have any good ways to eliminate the format issue shown in https://github.com/godotengine/godot-demo-projects/actions/runs/14484485384/job/40627594851?pr=1191? Thanks! |
There's trailing whitespace in the files. You can remove it by saving the impacted files with a text editor that has its "Trim Trailing Whitespace on Save" option enabled. That said, I can handle this since there are many changes that need to be done before the demo can be merged. |
Thank you! Please let me know if you will need any help. |
@Calinou Just following up. Are there anything I can help for this PR? Thanks. |
91f0df4
to
2f319f6
Compare
I've applied changes to the demo to polish it up, it should be good to merge now. Thanks a lot for submitting this demo 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Congratulations for your first merged pull request 🎉
Thank you @Calinou !~ |
b114664
to
2d78dca
Compare
2d78dca
to
2f88691
Compare
Finish demoing the project and implementing Sprite3D and AnimatedSprite3D. Also, provide game visual effects using shaders.
TODO: The link to the demo on the asset library in the README needs to be added.
Related to #1173