Skip to content

Add an about page for the Godot XR Editor #10083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

Add an about page for the Godot XR Editor #10083

merged 1 commit into from
Oct 18, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Oct 14, 2024

No description provided.

@m4gr3d m4gr3d added enhancement topic:xr Related to XR documentation topic:porting labels Oct 14, 2024
@m4gr3d m4gr3d added this to the 4.4 milestone Oct 14, 2024
@m4gr3d m4gr3d force-pushed the add_xr_editor_page branch from 633da7d to f7dbd89 Compare October 14, 2024 14:48
AThousandShips
AThousandShips reviewed Oct 14, 2024
View reviewed changes
@m4gr3d m4gr3d force-pushed the add_xr_editor_page branch from f7dbd89 to 2606469 Compare October 14, 2024 15:13
devloglogan
devloglogan reviewed Oct 14, 2024
View reviewed changes
@devloglogan
Copy link
Contributor

Is it worth mentioning why there is no Quest 2 support, considering a decent number of people seem to ask about that?

@m4gr3d m4gr3d force-pushed the add_xr_editor_page branch 4 times, most recently from 5fc0894 to e94f116 Compare October 14, 2024 15:44
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Oct 14, 2024

@AThousandShips @devloglogan Thanks for the feedback! I've addressed your comments.

@skyace65 skyace65 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Oct 15, 2024
@m4gr3d m4gr3d requested a review from fire October 15, 2024 12:58
fire
fire approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. I want to mention that gdextension works if you use godot cpp template to build your gdextension for android or other means via github actions

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Oct 15, 2024

Looks ok. I want to mention that gdextension works if you use godot cpp template to build your gdextension for android or other means via github actions

Good point, I'll add that as well.
Funny enough, while gdextension plugins work, Android plugins do not as they require gradle build support which both the Android and XR editor do not yet have.

@m4gr3d m4gr3d force-pushed the add_xr_editor_page branch from e94f116 to 6637873 Compare October 16, 2024 17:50
@mhilbrunner mhilbrunner merged commit 3aea17e into godotengine:master Oct 18, 2024
1 check passed
@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 18, 2024 •
edited
Loading

Thank you, great work! And thanks everyone for the reviews! If anyone still notices anything, followup PRs are welcome, I'll merge this now :)

@m4gr3d m4gr3d deleted the add_xr_editor_page branch October 18, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devloglogan devloglogan devloglogan left review comments

@fire fire fire approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

@Calinou Calinou Awaiting requested review from Calinou

@dsnopek dsnopek Awaiting requested review from dsnopek

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:porting topic:xr Related to XR documentation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@m4gr3d @devloglogan @mhilbrunner @fire @AThousandShips @skyace65