Skip to content

Update the Android build documentation #10886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 21, 2025

doc maintainer edit, waiting on this PR now: godotengine/godot#105671

@m4gr3d m4gr3d added this to the 4.5 milestone Apr 21, 2025
@m4gr3d m4gr3d requested review from Calinou and a team April 21, 2025 15:18
@skyace65 skyace65 added the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Apr 21, 2025
Copy link
Member

@syntaxerror247 syntaxerror247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note about gradle_do_not_strip.

@m4gr3d m4gr3d force-pushed the update_generate_apk_docs branch 3 times, most recently from 0fb716e to c50c6ea Compare April 22, 2025 17:45
@m4gr3d m4gr3d requested a review from syntaxerror247 April 22, 2025 17:46
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 23, 2025

Blocked by godotengine/godot#105671

@m4gr3d m4gr3d force-pushed the update_generate_apk_docs branch from c50c6ea to 3dad873 Compare April 24, 2025 15:38
@m4gr3d m4gr3d changed the title Replace generate_apk with generate_android_binaries in the Android documentation Update the Android build documentation Apr 24, 2025
@mhilbrunner mhilbrunner removed the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Apr 28, 2025
@mhilbrunner
Copy link
Member

@m4gr3d Assuming this is good to go now that that PR got merged?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 29, 2025

@m4gr3d Assuming this is good to go now that that PR got merged?

@mhilbrunner not yet, I need to update the documentation with the parameter we went with in the referenced PR. I'll do it right away.

- Replace `generate_apk` with `generate_android_binaries` in the Android documentation
- Update the ndk version to 27.2.12479018
@m4gr3d m4gr3d force-pushed the update_generate_apk_docs branch from 3dad873 to ddbc8e8 Compare April 29, 2025 02:20
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 29, 2025

@m4gr3d Assuming this is good to go now that that PR got merged?

@mhilbrunner not yet, I need to update the documentation with the parameter we went with in the referenced PR. I'll do it right away.

@mhilbrunner It's ready to go now!

@skyace65 skyace65 merged commit 530614a into godotengine:master May 1, 2025
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented May 1, 2025

Thanks!

@skyace65
Copy link
Contributor

skyace65 commented May 2, 2025

Note to whoever cherrypicks this. Check that the engine PRs this one links to have been cherrypicked first.

@m4gr3d m4gr3d deleted the update_generate_apk_docs branch May 2, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants