Skip to content

Conversation

@BlueberryGecko
Copy link

@BlueberryGecko BlueberryGecko commented Oct 29, 2025

Imo the handedness of angles in the documentation images for methods such as Vector2.angle_to should be explicitly shown.

My hope is that this adds visual clarification/intuition that:

  1. these three methods could return negative angles (counterclockwise)
  2. the methods are not symmetric (e.g. a.angle_to(b) != b.angle_to(a))
  3. Godot's angles increase in clockwise direction (pretty standard in computer graphics, but easy to confuse beginners).

@Calinou Calinou added enhancement content:images Issues and PRs involving outdated or incorrect images in articles area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository labels Oct 30, 2025
@BlueberryGecko
Copy link
Author

Seems there was a CI issue that got fixed in master, so I rebased.

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and thanks for the rebase! Would you mind taking the chance to convert these images to WebP? We're in the process of moving images over to WebP whenever we update existing ones, see image contribution guidelines for details.

@BlueberryGecko BlueberryGecko force-pushed the vector2-angle-images branch 2 times, most recently from 247acb2 to 0a58f5a Compare November 2, 2025 11:13
@mhilbrunner
Copy link
Member

@BlueberryGecko Much appreciated! Note that the classes/class_vector2.rst file is autogenerated from the source in the main engine repository, as noted at the top of the file, so the changes to that file will get lost. You need to transfer those few changes to a separate PR on the main repository, in this source file: https://github.com/godotengine/godot/blob/master/doc/classes/Vector2.xml

@BlueberryGecko
Copy link
Author

BlueberryGecko commented Nov 3, 2025

@BlueberryGecko Much appreciated! Note that the classes/class_vector2.rst file is autogenerated from the source in the main engine repository, as noted at the top of the file, so the changes to that file will get lost. You need to transfer those few changes to a separate PR on the main repository, in this source file: https://github.com/godotengine/godot/blob/master/doc/classes/Vector2.xml

Ah, that should have been somewhat obvious... I opened the PR (godotengine/godot#112341). I assume the PRs have to be merged somewhat in sync? Let me know if there's anything more I need to do for that.

(I removed the changes to the .rst here and amended the commit. I hope that's correct now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository content:images Issues and PRs involving outdated or incorrect images in articles enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants