Improve explanations around shader language's TIME variable (3.2)
#4283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
changed the title
TIME variableTIME variable (3.2)
Calinou
commented
Oct 17, 2020
| @@ -51,8 +51,12 @@ Global built-ins are available everywhere, including custom functions. | |||
| +-------------------+-----------------------------------------------------------------------------+ | |||
| | Built-in | Description | | |||
| +===================+=============================================================================+ | |||
| | in float **TIME** | Global time, in seconds. | | |||
| | | It's subject to the rollover setting (which is 3,600 -1 hour- by default). | | |||
| | in float **TIME** | Global time since the shader was compiled, in seconds (always positive). | | |||
There was a problem hiding this comment.
Is this time actually reset when the shader was compiled outside the editor? I'm not sure.
There was a problem hiding this comment.
@clayjohn would you know about this? Also, is compiling shaders outside Godot officially supported? If not, it's fine to merge as-is.
There was a problem hiding this comment.
I dont think it resets when the shader is recompiled. TIME comes from frame.time which is incremented in the rasterizer.
|
Thanks much and sorry for the delay! |
This was referenced Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Opened against the
3.2branch asVisualServer.set_shader_time_scale()is only available in 3.2.x, not 4.0. This is because global uniforms provide a way for users to replace this feature in 4.0.This closes #4282.