Skip to content

Update D3D12 build instructions. #8624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2023
Merged

Update D3D12 build instructions. #8624

merged 1 commit into from
Dec 24, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 14, 2023 •
edited
Loading

Removes MSVC only note, adds extra info for MinGW build.

Depends on godotengine/godot#83452

@bruvzg bruvzg added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation topic:buildsystem waiting on PR merge PR's that can't be merged until an engine PR is merged first labels Dec 14, 2023
@bruvzg bruvzg added this to the 4.3 milestone Dec 14, 2023
@bruvzg bruvzg mentioned this pull request Dec 14, 2023
Closed
@mhilbrunner mhilbrunner marked this pull request as draft December 14, 2023 14:54
@mhilbrunner
Copy link
Member

Converted to draft until the above PR is merged.

@bruvzg bruvzg marked this pull request as ready for review December 20, 2023 19:12
@growingbrain
Copy link
Contributor

growingbrain commented Dec 21, 2023 •
edited
Loading

Although this change was not made in this review.
Noticed that the color highlighting is odd for:
C:\godot>
Where the '\g' is yellow?
Also this line has odd coloring:
%USERPROFILE%\AppData\Roaming\Godot\templates<version>\

@AThousandShips
Copy link
Member

AThousandShips commented Dec 21, 2023 •
edited
Loading

The highlighting is unrelated to this section, it's due to the backslashes, which is treated as an escape I believe

I'd suggest opening an issue to track that 🙂

@bruvzg
Copy link
Member Author

bruvzg commented Dec 21, 2023

Noticed that the color highlighting is odd for

#8664

growingbrain
growingbrain reviewed Dec 22, 2023
View reviewed changes
contributing/development/compiling/compiling_for_windows.rst
@@ -214,6 +217,17 @@ Optionally, you can compile with the following for additional features:
.. note:: If you use a preview version of the Agility SDK, remember to enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 'preview' be 'previous'?
"If you use a previous version..."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. If you check https://devblogs.microsoft.com/directx/directx12agility/, you'll see that they release preview versions, which are like betas of upcoming releases. This sentence is about them.

@AThousandShips AThousandShips removed the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Dec 23, 2023
@skyace65 skyace65 merged commit cdd2141 into godotengine:master Dec 24, 2023
@skyace65
Copy link
Contributor

Thanks!

@Calinou Calinou mentioned this pull request Jan 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

@AThousandShips AThousandShips AThousandShips left review comments

@growingbrain growingbrain growingbrain left review comments

@skyace65 skyace65 skyace65 approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement topic:buildsystem
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@bruvzg @mhilbrunner @growingbrain @AThousandShips @skyace65 @RandomShaper