Skip to content

Fix properties' names stretched on mobile #8756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Cronos87
Copy link

This is my first contribution to Godot, I hope I did things well 😊

Fix issue #7504 where properties' names are stretched on mobile.

Before:

CleanShot 2024-01-12 at 12 18 53@2x

After:

CleanShot 2024-01-12 at 12 19 09@2x

@AThousandShips
Copy link
Member

See also:

Which already works on this issue 🙂

@AThousandShips AThousandShips added bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end labels Jan 12, 2024
@Cronos87
Copy link
Author

Cronos87 commented Jan 12, 2024

Yes indeed, I didn't know about this PR. It could be deployed as a temporary fix until this one fixes it better 🤔

@AThousandShips
Copy link
Member

It was linked to the relevant issue, good to know in the future that there's a list of linked PRs on issues that says they are there

Temporary fixes are usually not supported, but we'll see which solution ends up being the correct one 🙂

@YuriSizov
Copy link
Contributor

YuriSizov commented Jan 12, 2024

It could be deployed as a temporary fix until this one fixes it better 🤔

I think your PR doesn't help with usability, so fixing it even temporarily this way would just exchange one inconvenience for another. We really need to customize the layout itself on mobile, which #7542 attempts to do.

Any help with testing and finishing it would be appreciated!

Edit: Also, for future reference, please follow the structure of the edited file. Definitions for class reference pages are added below in their own dedicated section.

@Cronos87
Copy link
Author

That was silly of me. I understand now the way of thinking. I can help to fix using the PR you both mentioned.

Thank you! I close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants