Update list of spatial shader render modes for Godot 4.4 - #9691
Merged
skyace65 merged 1 commit intoJan 25, 2025
Conversation
Calinou
added
enhancement
area:manual
Calinou
commented
Aug 1, 2024
Comment on lines
+354
to
+388
| | out float **PREMUL_ALPHA_FACTOR** | Premultiplied alpha factor. Only effective if ``render_mode blend_premul_alpha;`` is used. | | ||
| | | This should be written to when using a *shaded* material with premultiplied alpha blending for | | ||
| | | interaction with lighting. This is not required for unshaded materials. | | ||
| +----------------------------------------+--------------------------------------------------------------------------------------------------+ |
Member
Author
There was a problem hiding this comment.
Any ideas of a concrete example? I've based this description on the existing class reference, but it's not really obvious how you're supposed to write to it in a typical shaded PBR material scenario.
Calinou
force-pushed
the
spatial-shader-update-render-modes
branch
from
August 1, 2024 02:01
a74c89d to
cce46dc
Compare
Calinou
force-pushed
the
spatial-shader-update-render-modes
branch
from
August 3, 2024 20:49
cce46dc to
6001307
Compare
tetrapod00
reviewed
Aug 14, 2024
Calinou
force-pushed
the
spatial-shader-update-render-modes
branch
from
January 24, 2025 17:13
6001307 to
07c01f5
Compare
Member
Author
|
Rebased and fleshed out with more descriptions – everything is now documented 🙂 |
tetrapod00
requested changes
Jan 24, 2025
tetrapod00
left a comment
tetrapod00
left a comment
Contributor
There was a problem hiding this comment.
Besides the one comment about vertex lighting, seems fine to merge from my user's understanding of shaders.
This also improves the documentation for existing render modes.
Calinou
force-pushed
the
spatial-shader-update-render-modes
branch
from
January 25, 2025 17:43
07c01f5 to
e43dd08
Compare
skyace65
changed the title
Member
|
@tetrapod00 I'm going to go through this for grammar and spelling in a bit, any other changes you want before this is merged? |
tetrapod00
approved these changes
Jan 25, 2025
Contributor
|
@skyace65 No, that was the only thing; this looks good to merge now. |
skyace65
approved these changes
Jan 25, 2025
skyace65
left a comment
skyace65
left a comment
Member
There was a problem hiding this comment.
Spelling and grammar wise everything looks good
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also improves the documentation for existing render modes.
specular_disabledrender mode in shaders does not make theSPECULARoutput zero godot#95102and closes Missing description on "Spatial shaders" page for "Fragment built-ins" - "in mat3 MODEL_NORMAL_MATRIX" #10522.
unshadedrender mode for quad in Advanced post-processing #9690.