Skip to content

Conversation

@JohnSoellnerDev
Copy link
Contributor

Overview

This PR is adding a new "Hide Bugs" option to the release notes component. Now, users can toggle the visibility of pull requests labeled "bug." This will help declutter the release notes view, allowing users to focus on non-bug changes.

Benefits

  • Improved Usability: Users now have the option to filter out bug related pull requests from the release notes. This makes it easier for users to focus on new features and other improvements.

Showcase

Bildschirmaufnahme_20250207_183815.webm

Looking forward to your input!

@JohnSoellnerDev
Copy link
Contributor Author

Hey @akien-mga Could you provide an update on this PR? It would be great if it could be reviewed. Also, is this a feature that you would like to integrate into the project? 😁

@Calinou Calinou added the enhancement New feature or request label Mar 6, 2025
@JohnSoellnerDev JohnSoellnerDev force-pushed the add-the-ability-to-hide-bug-fixes branch from dbaa65f to 2256bc8 Compare March 6, 2025 19:44
@JohnSoellnerDev JohnSoellnerDev requested a review from Calinou March 6, 2025 19:47
@akien-mga
Copy link
Member

The implementation seems fine, but I don't know if the feature is actually desired. We'd need to hear more from the community on whether they'd want to have this specific filter.

I could imagine a request for more filtering options, but just filtering out bug fixes seems a bit specific and peculiar to me. I'm assuming your goal is to mostly see new features. So what about documentation updates or typo fixes? What about a filter to highlight regression fixes? Personally, having a filter to see only bug fixes also seems quite worthwhile, as users often want to know if "their" favorite bug has been tackled.

So IMO this needs a bit more design thinking.

UI wise, I'm also not too fond of the checkbox there. I haven't given much thought yet to what would be better though, but that kind of depends on whether we want to implement more extensive filter options.

@JohnSoellnerDev
Copy link
Contributor Author

The implementation seems fine, but I don't know if the feature is actually desired. We'd need to hear more from the community on whether they'd want to have this specific filter.

I could imagine a request for more filtering options, but just filtering out bug fixes seems a bit specific and peculiar to me. I'm assuming your goal is to mostly see new features. So what about documentation updates or typo fixes? What about a filter to highlight regression fixes? Personally, having a filter to see only bug fixes also seems quite worthwhile, as users often want to know if "their" favorite bug has been tackled.

So IMO this needs a bit more design thinking.

UI wise, I'm also not too fond of the checkbox there. I haven't given much thought yet to what would be better though, but that kind of depends on whether we want to implement more extensive filter options.

Thanks for your feedback. I understand what you mean.

Considering your points, we could maybe implement a dropdown menu that allows users to manually select the labels they want to include. Items that do not have the selected labels would be filtered out.

@JohnSoellnerDev JohnSoellnerDev force-pushed the add-the-ability-to-hide-bug-fixes branch 3 times, most recently from a9c57a8 to 499968c Compare March 7, 2025 19:23
@JohnSoellnerDev
Copy link
Contributor Author

Hey @akien-mga,

I have now implemented the dropdown menu. One thing I would like to ask is how we should handle the availableLabels. Should we hardcode them or maybe fetch them from GitHub somehow and what other labels should we use to filter? 🙂

Bildschirmaufnahme_20250307_202640.webm

@JohnSoellnerDev JohnSoellnerDev force-pushed the add-the-ability-to-hide-bug-fixes branch from 499968c to fa98bca Compare March 7, 2025 19:39
@JohnSoellnerDev JohnSoellnerDev changed the title Add "Hide Bugs" Option to Release Notes Add Label Filtering to Release Notes with Dropdown Menu Mar 7, 2025
@akien-mga akien-mga force-pushed the master branch 2 times, most recently from f694af5 to 573d6cb Compare March 14, 2025 00:25
@JohnSoellnerDev
Copy link
Contributor Author

This Pull Request is ready for review again 🙂

@adamscott adamscott self-requested a review April 12, 2025 15:27
@JohnSoellnerDev
Copy link
Contributor Author

Hello everyone, is there any news about this PR or anything else I should adjust? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants