Skip to content

Commit c434c45

Browse files
authored
Merge pull request #117990 from aaronfranke/4.5-metal_264
[4.5] Fix Metal driver build with Xcode 26.4
2 parents 04a42ce + 9e453f2 commit c434c45

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

drivers/metal/metal_objects.mm

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2031,11 +2031,11 @@ fragment ClearColorsOut fragClear(VaryingsPos varyings [[stage_in]], constant Cl
20312031
}
20322032

20332033
static const char *SHADER_STAGE_NAMES[] = {
2034-
[RD::SHADER_STAGE_VERTEX] = "vert",
2035-
[RD::SHADER_STAGE_FRAGMENT] = "frag",
2036-
[RD::SHADER_STAGE_TESSELATION_CONTROL] = "tess_ctrl",
2037-
[RD::SHADER_STAGE_TESSELATION_EVALUATION] = "tess_eval",
2038-
[RD::SHADER_STAGE_COMPUTE] = "comp",
2034+
"vert", // [RD::SHADER_STAGE_VERTEX]
2035+
"frag", // [RD::SHADER_STAGE_FRAGMENT]
2036+
"tess_ctrl", // [RD::SHADER_STAGE_TESSELATION_CONTROL]
2037+
"tess_eval", // [RD::SHADER_STAGE_TESSELATION_EVALUATION]
2038+
"comp", // [RD::SHADER_STAGE_COMPUTE]
20392039
};
20402040

20412041
void ShaderCacheEntry::notify_free() const {

drivers/metal/pixel_formats.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ void clear(T *p_val, size_t p_count = 1) {
576576

577577
void PixelFormats::addMTLPixelFormatDescImpl(MTLPixelFormat p_pix_fmt, MTLPixelFormat p_pix_fmt_linear,
578578
MTLViewClass p_view_class, MTLFmtCaps p_fmt_caps, const char *p_name) {
579-
_mtl_pixel_format_descs[p_pix_fmt] = { .mtlPixelFormat = p_pix_fmt, DataFormat::DATA_FORMAT_MAX, p_fmt_caps, p_view_class, p_pix_fmt_linear, p_name };
579+
_mtl_pixel_format_descs[p_pix_fmt] = { .mtlPixelFormat = p_pix_fmt, .dataFormat = DataFormat::DATA_FORMAT_MAX, .mtlFmtCaps = p_fmt_caps, .mtlViewClass = p_view_class, .mtlPixelFormatLinear = p_pix_fmt_linear, .name = p_name };
580580
}
581581

582582
#define addMTLPixelFormatDescFull(mtlFmt, mtlFmtLinear, viewClass, appleGPUCaps) \
@@ -778,7 +778,7 @@ void clear(T *p_val, size_t p_count = 1) {
778778
if (mtlVtxFmt >= _mtl_vertex_format_descs.size()) {
779779
_mtl_vertex_format_descs.resize(mtlVtxFmt + 1);
780780
}
781-
_mtl_vertex_format_descs[mtlVtxFmt] = { .mtlVertexFormat = mtlVtxFmt, RD::DATA_FORMAT_MAX, vtxCap, MTLViewClass::None, MTLPixelFormatInvalid, name };
781+
_mtl_vertex_format_descs[mtlVtxFmt] = { .mtlVertexFormat = mtlVtxFmt, .dataFormat = RD::DATA_FORMAT_MAX, .mtlFmtCaps = vtxCap, .mtlViewClass = MTLViewClass::None, .mtlPixelFormatLinear = MTLPixelFormatInvalid, .name = name };
782782
}
783783

784784
// Check mtlVtx exists on platform, to avoid overwriting the MTLVertexFormatInvalid entry.

drivers/metal/rendering_device_driver_metal.mm

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1832,14 +1832,14 @@ bool isArrayTexture(MTLTextureType p_type) {
18321832
}
18331833

18341834
static const MTLLoadAction LOAD_ACTIONS[] = {
1835-
[ATTACHMENT_LOAD_OP_LOAD] = MTLLoadActionLoad,
1836-
[ATTACHMENT_LOAD_OP_CLEAR] = MTLLoadActionClear,
1837-
[ATTACHMENT_LOAD_OP_DONT_CARE] = MTLLoadActionDontCare,
1835+
MTLLoadActionLoad, // [ATTACHMENT_LOAD_OP_LOAD]
1836+
MTLLoadActionClear, // [ATTACHMENT_LOAD_OP_CLEAR]
1837+
MTLLoadActionDontCare, // [ATTACHMENT_LOAD_OP_DONT_CARE]
18381838
};
18391839

18401840
static const MTLStoreAction STORE_ACTIONS[] = {
1841-
[ATTACHMENT_STORE_OP_STORE] = MTLStoreActionStore,
1842-
[ATTACHMENT_STORE_OP_DONT_CARE] = MTLStoreActionDontCare,
1841+
MTLStoreActionStore, // [ATTACHMENT_STORE_OP_STORE]
1842+
MTLStoreActionDontCare, // [ATTACHMENT_STORE_OP_DONT_CARE]
18431843
};
18441844

18451845
Vector<MDAttachment> attachments;

0 commit comments

Comments
 (0)