Skip to content

Commit d666f67

Browse files
dsnopekaaronfranke
dsnopek
and
aaronfranke
committed
Make Vector<T>::duplicate() const
Co-authored-by: Aaron Franke <[email protected]>
1 parent 417329d commit d666f67

File tree

13 files changed

+64
-11
lines changed

13 files changed

+64
-11
lines changed

‎core/templates/vector.h‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,16 @@ class Vector {
184184
return span().bisect(p_value, p_before, Comparator{ args... });
185185
}
186186

187-
Vector<T> duplicate() {
187+
Vector<T> duplicate() const {
188188
return *this;
189189
}
190190

191+
#ifndef DISABLE_DEPRECATED
192+
Vector<T> _duplicate_bind_compat_79140() {
193+
return *this;
194+
}
195+
#endif // DISABLE_DEPRECATED
196+
191197
void ordered_insert(const T &p_val) {
192198
Size i;
193199
for (i = 0; i < _cowdata.size(); i++) {

‎core/variant/variant_call.cpp‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2748,6 +2748,9 @@ static void _register_variant_builtin_methods_array() {
27482748
bind_method(PackedByteArray, sort, sarray(), varray());
27492749
bind_method(PackedByteArray, bsearch, sarray("value", "before"), varray(true));
27502750
bind_method(PackedByteArray, duplicate, sarray(), varray());
2751+
#ifndef DISABLE_DEPRECATED
2752+
bind_compat_method(PackedByteArray, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
2753+
#endif
27512754
bind_method(PackedByteArray, find, sarray("value", "from"), varray(0));
27522755
bind_method(PackedByteArray, rfind, sarray("value", "from"), varray(-1));
27532756
bind_method(PackedByteArray, count, sarray("value"), varray());
@@ -2824,6 +2827,9 @@ static void _register_variant_builtin_methods_array() {
28242827
bind_method(PackedInt32Array, sort, sarray(), varray());
28252828
bind_method(PackedInt32Array, bsearch, sarray("value", "before"), varray(true));
28262829
bind_method(PackedInt32Array, duplicate, sarray(), varray());
2830+
#ifndef DISABLE_DEPRECATED
2831+
bind_compat_method(PackedInt32Array, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
2832+
#endif
28272833
bind_method(PackedInt32Array, find, sarray("value", "from"), varray(0));
28282834
bind_method(PackedInt32Array, rfind, sarray("value", "from"), varray(-1));
28292835
bind_method(PackedInt32Array, count, sarray("value"), varray());
@@ -2848,6 +2854,9 @@ static void _register_variant_builtin_methods_array() {
28482854
bind_method(PackedInt64Array, sort, sarray(), varray());
28492855
bind_method(PackedInt64Array, bsearch, sarray("value", "before"), varray(true));
28502856
bind_method(PackedInt64Array, duplicate, sarray(), varray());
2857+
#ifndef DISABLE_DEPRECATED
2858+
bind_compat_method(PackedInt64Array, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
2859+
#endif
28512860
bind_method(PackedInt64Array, find, sarray("value", "from"), varray(0));
28522861
bind_method(PackedInt64Array, rfind, sarray("value", "from"), varray(-1));
28532862
bind_method(PackedInt64Array, count, sarray("value"), varray());
@@ -2872,6 +2881,9 @@ static void _register_variant_builtin_methods_array() {
28722881
bind_method(PackedFloat32Array, sort, sarray(), varray());
28732882
bind_method(PackedFloat32Array, bsearch, sarray("value", "before"), varray(true));
28742883
bind_method(PackedFloat32Array, duplicate, sarray(), varray());
2884+
#ifndef DISABLE_DEPRECATED
2885+
bind_compat_method(PackedFloat32Array, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
2886+
#endif
28752887
bind_method(PackedFloat32Array, find, sarray("value", "from"), varray(0));
28762888
bind_method(PackedFloat32Array, rfind, sarray("value", "from"), varray(-1));
28772889
bind_method(PackedFloat32Array, count, sarray("value"), varray());
@@ -2896,6 +2908,9 @@ static void _register_variant_builtin_methods_array() {
28962908
bind_method(PackedFloat64Array, sort, sarray(), varray());
28972909
bind_method(PackedFloat64Array, bsearch, sarray("value", "before"), varray(true));
28982910
bind_method(PackedFloat64Array, duplicate, sarray(), varray());
2911+
#ifndef DISABLE_DEPRECATED
2912+
bind_compat_method(PackedFloat64Array, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
2913+
#endif
28992914
bind_method(PackedFloat64Array, find, sarray("value", "from"), varray(0));
29002915
bind_method(PackedFloat64Array, rfind, sarray("value", "from"), varray(-1));
29012916
bind_method(PackedFloat64Array, count, sarray("value"), varray());
@@ -2920,6 +2935,9 @@ static void _register_variant_builtin_methods_array() {
29202935
bind_method(PackedStringArray, sort, sarray(), varray());
29212936
bind_method(PackedStringArray, bsearch, sarray("value", "before"), varray(true));
29222937
bind_method(PackedStringArray, duplicate, sarray(), varray());
2938+
#ifndef DISABLE_DEPRECATED
2939+
bind_compat_method(PackedStringArray, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
2940+
#endif
29232941
bind_method(PackedStringArray, find, sarray("value", "from"), varray(0));
29242942
bind_method(PackedStringArray, rfind, sarray("value", "from"), varray(-1));
29252943
bind_method(PackedStringArray, count, sarray("value"), varray());
@@ -2944,6 +2962,9 @@ static void _register_variant_builtin_methods_array() {
29442962
bind_method(PackedVector2Array, sort, sarray(), varray());
29452963
bind_method(PackedVector2Array, bsearch, sarray("value", "before"), varray(true));
29462964
bind_method(PackedVector2Array, duplicate, sarray(), varray());
2965+
#ifndef DISABLE_DEPRECATED
2966+
bind_compat_method(PackedVector2Array, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
2967+
#endif
29472968
bind_method(PackedVector2Array, find, sarray("value", "from"), varray(0));
29482969
bind_method(PackedVector2Array, rfind, sarray("value", "from"), varray(-1));
29492970
bind_method(PackedVector2Array, count, sarray("value"), varray());
@@ -2968,6 +2989,9 @@ static void _register_variant_builtin_methods_array() {
29682989
bind_method(PackedVector3Array, sort, sarray(), varray());
29692990
bind_method(PackedVector3Array, bsearch, sarray("value", "before"), varray(true));
29702991
bind_method(PackedVector3Array, duplicate, sarray(), varray());
2992+
#ifndef DISABLE_DEPRECATED
2993+
bind_compat_method(PackedVector3Array, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
2994+
#endif
29712995
bind_method(PackedVector3Array, find, sarray("value", "from"), varray(0));
29722996
bind_method(PackedVector3Array, rfind, sarray("value", "from"), varray(-1));
29732997
bind_method(PackedVector3Array, count, sarray("value"), varray());
@@ -2992,6 +3016,9 @@ static void _register_variant_builtin_methods_array() {
29923016
bind_method(PackedColorArray, sort, sarray(), varray());
29933017
bind_method(PackedColorArray, bsearch, sarray("value", "before"), varray(true));
29943018
bind_method(PackedColorArray, duplicate, sarray(), varray());
3019+
#ifndef DISABLE_DEPRECATED
3020+
bind_compat_method(PackedColorArray, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
3021+
#endif
29953022
bind_method(PackedColorArray, find, sarray("value", "from"), varray(0));
29963023
bind_method(PackedColorArray, rfind, sarray("value", "from"), varray(-1));
29973024
bind_method(PackedColorArray, count, sarray("value"), varray());
@@ -3016,6 +3043,9 @@ static void _register_variant_builtin_methods_array() {
30163043
bind_method(PackedVector4Array, sort, sarray(), varray());
30173044
bind_method(PackedVector4Array, bsearch, sarray("value", "before"), varray(true));
30183045
bind_method(PackedVector4Array, duplicate, sarray(), varray());
3046+
#ifndef DISABLE_DEPRECATED
3047+
bind_compat_method(PackedVector4Array, duplicate, _duplicate_bind_compat_79140, sarray(), varray());
3048+
#endif
30193049
bind_method(PackedVector4Array, find, sarray("value", "from"), varray(0));
30203050
bind_method(PackedVector4Array, rfind, sarray("value", "from"), varray(-1));
30213051
bind_method(PackedVector4Array, count, sarray("value"), varray());

‎doc/classes/PackedByteArray.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@
213213
[b]Note:[/b] Decompression is not guaranteed to work with data not compressed by Godot, for example if data compressed with the deflate compression mode lacks a checksum or header.
214214
</description>
215215
</method>
216-
<method name="duplicate">
216+
<method name="duplicate" qualifiers="const">
217217
<return type="PackedByteArray" />
218218
<description>
219219
Creates a copy of the array, and returns it.

‎doc/classes/PackedColorArray.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
Returns the number of times an element is in the array.
7474
</description>
7575
</method>
76-
<method name="duplicate">
76+
<method name="duplicate" qualifiers="const">
7777
<return type="PackedColorArray" />
7878
<description>
7979
Creates a copy of the array, and returns it.

‎doc/classes/PackedFloat32Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
[b]Note:[/b] [constant @GDScript.NAN] doesn't behave the same as other numbers. Therefore, the results from this method may not be accurate if NaNs are included.
7272
</description>
7373
</method>
74-
<method name="duplicate">
74+
<method name="duplicate" qualifiers="const">
7575
<return type="PackedFloat32Array" />
7676
<description>
7777
Creates a copy of the array, and returns it.

‎doc/classes/PackedFloat64Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
[b]Note:[/b] [constant @GDScript.NAN] doesn't behave the same as other numbers. Therefore, the results from this method may not be accurate if NaNs are included.
7373
</description>
7474
</method>
75-
<method name="duplicate">
75+
<method name="duplicate" qualifiers="const">
7676
<return type="PackedFloat64Array" />
7777
<description>
7878
Creates a copy of the array, and returns it.

‎doc/classes/PackedInt32Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
Returns the number of times an element is in the array.
7070
</description>
7171
</method>
72-
<method name="duplicate">
72+
<method name="duplicate" qualifiers="const">
7373
<return type="PackedInt32Array" />
7474
<description>
7575
Creates a copy of the array, and returns it.

‎doc/classes/PackedInt64Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
Returns the number of times an element is in the array.
7171
</description>
7272
</method>
73-
<method name="duplicate">
73+
<method name="duplicate" qualifiers="const">
7474
<return type="PackedInt64Array" />
7575
<description>
7676
Creates a copy of the array, and returns it.

‎doc/classes/PackedStringArray.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
Returns the number of times an element is in the array.
7777
</description>
7878
</method>
79-
<method name="duplicate">
79+
<method name="duplicate" qualifiers="const">
8080
<return type="PackedStringArray" />
8181
<description>
8282
Creates a copy of the array, and returns it.

‎doc/classes/PackedVector2Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
[b]Note:[/b] Vectors with [constant @GDScript.NAN] elements don't behave the same as other vectors. Therefore, the results from this method may not be accurate if NaNs are included.
7777
</description>
7878
</method>
79-
<method name="duplicate">
79+
<method name="duplicate" qualifiers="const">
8080
<return type="PackedVector2Array" />
8181
<description>
8282
Creates a copy of the array, and returns it.

0 commit comments

Comments
 (0)