Skip to content

Follow system theme causes config file churn #101767

Open
@rcorre

Description

Tested versions

4.3.stable.arch_linux

System information

Godot v4.3.stable unknown - Arch Linux #1 SMP PREEMPT_DYNAMIC Fri, 10 Jan 2025 00:39:41 +0000 - Wayland - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (nvidia; 565.77) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)

Issue description

I have godot's theme set to "Follow System Theme". I also commit ~/.config/godot/editor_settings-4.3.tres in my dotfiles, to synchronize changes across devices.

The issue is that whenever I toggle my system theme, godot changes a bunch of fields in the config file. For ease of use across machines, the config should reflect more persistent options, not things that frequently change due to outside influence like the system theme changing. That is, it would be nice if the config just stored "Use System Theme" as a setting instead of changing all these each time the system theme changes:

-interface/theme/preset = "Light"
-interface/theme/base_color = Color(0.9, 0.9, 0.9, 1)
-interface/theme/accent_color = Color(0.18, 0.5, 1, 1)
-interface/theme/contrast = -0.06
+interface/theme/base_color = Color(0.21, 0.24, 0.29, 1)
+interface/theme/accent_color = Color(0.44, 0.73, 0.98, 1)
+interface/theme/contrast = 0.3
 filesystem/import/blender/blender_path = "/usr/bin//blender"
 filesystem/import/blender/rpc_port = 0
-text_editor/theme/highlighting/symbol_color = Color(0, 0, 0.61, 1)
-text_editor/theme/highlighting/keyword_color = Color(0.9, 0.135, 0.51, 1)
-text_editor/theme/highlighting/control_flow_keyword_color = Color(0.743, 0.12, 0.8, 1)
-text_editor/theme/highlighting/base_type_color = Color(0, 0.6, 0.2, 1)
-text_editor/theme/highlighting/engine_type_color = Color(0.11, 0.55, 0.4, 1)
-text_editor/theme/highlighting/user_type_color = Color(0.18, 0.45, 0.4, 1)
-text_editor/theme/highlighting/comment_color = Color(0.08, 0.08, 0.08, 0.5)
-text_editor/theme/highlighting/doc_comment_color = Color(0.15, 0.15, 0.4, 0.7)
-text_editor/theme/highlighting/string_color = Color(0.6, 0.42, 0, 1)
-text_editor/theme/highlighting/background_color = Color(1, 1, 1, 1)
-text_editor/theme/highlighting/completion_background_color = Color(0.981, 0.981, 0.981, 1)
-text_editor/theme/highlighting/completion_selected_color = Color(0, 0, 0, 0.07)
-text_editor/theme/highlighting/completion_existing_color = Color(0, 0, 0, 0.14)
-text_editor/theme/highlighting/completion_scroll_color = Color(0, 0, 0, 0.29)
-text_editor/theme/highlighting/completion_scroll_hovered_color = Color(0, 0, 0, 0.4)
-text_editor/theme/highlighting/completion_font_color = Color(0.225, 0.225, 0.225, 1)
-text_editor/theme/highlighting/text_color = Color(0.225, 0.225, 0.225, 1)
-text_editor/theme/highlighting/line_number_color = Color(0.225, 0.225, 0.225, 0.5)
-text_editor/theme/highlighting/safe_line_number_color = Color(0, 0.4, 0, 0.75)
-text_editor/theme/highlighting/caret_color = Color(0, 0, 0, 1)
-text_editor/theme/highlighting/caret_background_color = Color(1, 1, 1, 1)
-text_editor/theme/highlighting/selection_color = Color(0.18, 0.5, 1, 0.4)
-text_editor/theme/highlighting/brace_mismatch_color = Color(1, 0.08, 0, 1)
-text_editor/theme/highlighting/current_line_color = Color(0, 0, 0, 0.07)
-text_editor/theme/highlighting/line_length_guideline_color = Color(0.981, 0.981, 0.981, 1)
-text_editor/theme/highlighting/word_highlighted_color = Color(0, 0, 0, 0.07)
-text_editor/theme/highlighting/number_color = Color(0, 0.55, 0.28, 1)
-text_editor/theme/highlighting/function_color = Color(0, 0.225, 0.9, 1)
-text_editor/theme/highlighting/member_variable_color = Color(0, 0.4, 0.68, 1)
-text_editor/theme/highlighting/mark_color = Color(0.8, 0.22, 0.22, 0.3)
-text_editor/theme/highlighting/breakpoint_color = Color(1, 0.27, 0.2, 1)
-text_editor/theme/highlighting/code_folding_color = Color(0, 0, 0, 0.27)
-text_editor/theme/highlighting/search_result_color = Color(0, 0, 0, 0.07)
-text_editor/theme/highlighting/search_result_border_color = Color(0, 0.4, 1, 0.38)
+text_editor/theme/highlighting/symbol_color = Color(0.67, 0.79, 1, 1)
+text_editor/theme/highlighting/keyword_color = Color(1, 0.44, 0.52, 1)
+text_editor/theme/highlighting/control_flow_keyword_color = Color(1, 0.55, 0.8, 1)
+text_editor/theme/highlighting/base_type_color = Color(0.26, 1, 0.76, 1)
+text_editor/theme/highlighting/engine_type_color = Color(0.56, 1, 0.86, 1)
+text_editor/theme/highlighting/user_type_color = Color(0.78, 1, 0.93, 1)
+text_editor/theme/highlighting/comment_color = Color(0.8025, 0.81, 0.8225, 0.5)
+text_editor/theme/highlighting/doc_comment_color = Color(0.6, 0.7, 0.8, 0.8)
+text_editor/theme/highlighting/string_color = Color(1, 0.93, 0.63, 1)
+text_editor/theme/highlighting/background_color = Color(0.1155, 0.132, 0.1595, 1)
+text_editor/theme/highlighting/completion_background_color = Color(0.21, 0.24, 0.29, 1)
+text_editor/theme/highlighting/completion_selected_color = Color(1, 1, 1, 0.07)
+text_editor/theme/highlighting/completion_existing_color = Color(1, 1, 1, 0.14)
+text_editor/theme/highlighting/completion_font_color = Color(0.8025, 0.81, 0.8225, 1)
+text_editor/theme/highlighting/text_color = Color(0.8025, 0.81, 0.8225, 1)
+text_editor/theme/highlighting/line_number_color = Color(0.8025, 0.81, 0.8225, 0.5)
+text_editor/theme/highlighting/safe_line_number_color = Color(0.8025, 0.972, 0.8225, 0.75)
+text_editor/theme/highlighting/caret_color = Color(1, 1, 1, 1)
+text_editor/theme/highlighting/selection_color = Color(0.44, 0.73, 0.98, 0.4)
+text_editor/theme/highlighting/brace_mismatch_color = Color(1, 0.47, 0.42, 1)
+text_editor/theme/highlighting/current_line_color = Color(1, 1, 1, 0.07)
+text_editor/theme/highlighting/line_length_guideline_color = Color(0.21, 0.24, 0.29, 1)
+text_editor/theme/highlighting/word_highlighted_color = Color(1, 1, 1, 0.07)
+text_editor/theme/highlighting/number_color = Color(0.63, 1, 0.88, 1)
+text_editor/theme/highlighting/function_color = Color(0.34, 0.7, 1, 1)
+text_editor/theme/highlighting/member_variable_color = Color(0.736, 0.88, 1, 1)
+text_editor/theme/highlighting/mark_color = Color(1, 0.47, 0.42, 0.3)
+text_editor/theme/highlighting/breakpoint_color = Color(1, 0.47, 0.42, 1)
+text_editor/theme/highlighting/code_folding_color = Color(1, 1, 1, 0.27)
+text_editor/theme/highlighting/search_result_color = Color(1, 1, 1, 0.07)
 text_editor/behavior/files/trim_trailing_whitespace_on_save = true
 text_editor/behavior/files/auto_reload_scripts_on_external_change = true
 run/platforms/linuxbsd/prefer_wayland = true

Steps to reproduce

  1. Open godot and set "Follow System Theme" in the editor settings.
  2. Commit ~/.config/godot in a git repository.
  3. Change your system theme from light->dark
  4. Run git diff in the repository

Minimal reproduction project (MRP)

N/A

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions