Focusing text Control (e.g. TextEdit) maximizes game window in certain scenario

[mh114]

Tested versions

• Reproducible in 4.4.1.stable (Linux)
• Reproducible in v4.2.2.stable (Linux)
• Didn't seem to happen in Windows on my actual project (haven't tried MRP on Windows), so may be related to Linux window manager in use (I'm on Linux Mint Cinnamon, X11)

System information

Godot v4.4.1.stable - Linux Mint 22.1 (Xia) on X11 - X11 display driver, Multi-window, 1 monitor - OpenGL 3 (Compatibility) - NVIDIA GeForce RTX 4060 Ti (nvidia; 570.144) - AMD Ryzen 7 7700X 8-Core Processor (16 threads)

Issue description

Noticed a strange issue that has quite a specific scenario where it happens. I'm working on a tool app. When I maximize the window and restore it back ("un-maximize"), and then click/focus a text field (such as TextEdit or LineEdit), Godot suddenly maximizes the window again for no apparent reason.

Steps to reproduce

Open main.tscn, run the app. NOTE: "Embedded game view" must be disabled.

1. Maximize the window (for me double clicking on title bar works, also the Maximize-button)
2. Restore the window (un-maximize)
3. Click on text fields (or focus with Tab)
   • Window goes back to maximized state!
   • Does not happen always, but most of the time.
4. Do steps 1 and 2, but click on the button
   • Nothing happens, works as intended.

Interestingly, if the window is moved after step 2, clicking on a text field will not trigger the bug.

Minimal reproduction project (MRP)

maximize_bug.zip

[Rindbee]

I can reproduce it.

I can confirm that wd.maximized is not reset to false when unmaximizing by clicking the icon.

Set a breakpoint in the following place and click the button (step 4) during debugging to view the properties of wd.

godot/platform/linuxbsd/x11/display_server_x11.cpp

Line 5171 in 1cf573f

_set_input_focus(wd.x11_window, RevertToPointerRoot);

[Rindbee]

Another point to note is that enabling the option that calls OS::get_singleton()->set_low_processor_usage_mode(true); is also a key step to reproduce the issue.

That is, you need to enable application/run/low_processor_mode in the project settings for a project.

godot/editor/project_manager.cpp

Line 1309 in 0793c62

OS::get_singleton()->set_low_processor_usage_mode(true);

godot/editor/editor_node.cpp

Line 981 in 0793c62

OS::get_singleton()->set_low_processor_usage_mode(!update_continuously);

The issue can be reproduced both with the Project Manager and with the editor with interface/editor/update_continuously disabled (by default).

[mh114]

Another point to note is that enabling the option that calls OS::get_singleton()->set_low_processor_usage_mode(true); is also a key step to reproduce the issue.

Good find, didn't expect that to matter! Now I'm not sure if I tested without it when creating the MRP (and just forgot to mention it), or if I enabled the low processor mode immediately, as my actual app does use it.. 🤔