Skip to content

MovieWriterMJPEG doesn't work with module_jpg_enabled=no #90932

New issue
New issue
Open
#106013
Open
MovieWriterMJPEG doesn't work with module_jpg_enabled=no#90932
#106013
Labels
bugtopic:buildsystem
@kus04e4ek

Description

@kus04e4ek
kus04e4ek
opened on Apr 20, 2024

Tested versions

master [9bc49a6]

Issue description

MovieWriterMJPEG uses save_jpg_to_buffer which is only implemented in jpg module:

godot/servers/movie_writer/movie_writer_mjpeg.cpp

Line 196 in 4a01602

Vector<uint8_t> jpg_buffer = p_image->save_jpg_to_buffer(quality);

godot/modules/jpg/image_loader_jpegd.cpp

Line 211 in 4a01602

Image::save_jpg_buffer_func = _jpgd_buffer_save_func;

Without jpg module there will be no video, only audio.
Perhaps MovieWriterMJPEG should be moved to jpg module or an error should be displayed.

Steps to reproduce

Record a video to .avi file fomat.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugtopic:buildsystem

    Type

    No type

    Projects

    Buildsystem Issue Triage

    Status

    Fix pending review

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions