Node2D draw_string in gdscript or DrawString in C# dosen't work in godot 4.4.1

[aliule2020]

Tested versions

4.4.1

System information

windows 11- godot 4.4.1

Issue description

Node2D draw_string in gdscript or DrawString in C# dosen't work in godot 4.4.1

extends Node2D


# Called when the node enters the scene tree for the first time.
func _ready():
	pass # Replace with function body.


# Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
	pass
	
	
func _draw():
	var font = FontFile.new()
	font = load("res://font/simkai.ttf")
	draw_string(font, Vector2(100, 100), "Hello, Godot 4!")

or

using Godot;
using System;

public partial class main : Node2D
{
	// Called when the node enters the scene tree for the first time.
	public override void _Ready()
	{
	}

	// Called every frame. 'delta' is the elapsed time since the previous frame.
	public override void _Process(double delta)
	{
	}

	public override void _Draw()
	{
		base._Draw();
		FontFile font = new FontFile();
		font=GD.Load<FontFile>("res://font/simkai.ttf");
		this.DrawString(font,new Vector2(0,0),"你好",HorizontalAlignment.Left,-1,32,Colors.Red);
	}
}

Steps to reproduce

Node2D draw_string in gdscript or DrawString in C# dosen't work in godot 4.4.1

extends Node2D


# Called when the node enters the scene tree for the first time.
func _ready():
	pass # Replace with function body.


# Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
	pass
	
	
func _draw():
	var font = FontFile.new()
	font = load("res://font/simkai.ttf")
	draw_string(font, Vector2(100, 100), "Hello, Godot 4!")

or

using Godot;
using System;

public partial class main : Node2D
{
	// Called when the node enters the scene tree for the first time.
	public override void _Ready()
	{
	}

	// Called every frame. 'delta' is the elapsed time since the previous frame.
	public override void _Process(double delta)
	{
	}

	public override void _Draw()
	{
		base._Draw();
		FontFile font = new FontFile();
		font=GD.Load<FontFile>("res://font/simkai.ttf");
		this.DrawString(font,new Vector2(0,0),"你好",HorizontalAlignment.Left,-1,32,Colors.Red);
	}
}

Minimal reproduction project (MRP)

can't upload

Bugsquad edit: Fix code block formatting.

[kleonc]

func _draw():
  var font = FontFile.new()
  font = load("res://font/simkai.ttf")
  draw_string(font, Vector2(100, 100), "Hello, Godot 4!")

AFAICT the issue is that font is a local variable, and hence it's destructor is being called when exiting the method scope (as Resources are RefCounted and there is no other references making such font not be freed). In such destructor the TextServer side resources are being freed, making the issued rendering draw commands refer to invalid/freed data.

godot/scene/resources/font.cpp

Lines 2817 to 2819 in 19bb187

	FontFile::~FontFile() {
	_clear_cache();
	}

godot/scene/resources/font.cpp

Lines 577 to 584 in 19bb187

	_FORCE_INLINE_ void FontFile::_clear_cache() {
	for (int i = 0; i < cache.size(); i++) {
	if (cache[i].is_valid()) {
	TS->free_rid(cache[i]);
	cache.write[i] = RID();
	}
	}
	}

All you'd need to do is to make the used font not be freed as long as you're using it, e.g. by holding a reference to it in the class scope:

extends Node2D
	
var font: Font = load("res://font/simkai.ttf")

func _draw():
	draw_string(font, Vector2(100, 100), "Hello, Godot 4!")

[AThousandShips]

Probably a duplicate of:

• Drawing a texture obtained with load in _draw always fails #25296

[aliule2020]

extends Node2D

var font: Font = load("res://font/simkai.ttf")

func _draw():
draw_string(font, Vector2(100, 100), "Hello, Godot 4!")

it still has the same problem

[AThousandShips]

Try:

extends Node2D
	
var font: Font

func _ready():
	font = load("res://font/simkai.ttf")

func _draw():
	draw_string(font, Vector2(100, 100), "Hello, Godot 4!")

[aliule2020]

extends Node2D

var font: Font

func _ready():
font = load("res://font/simkai.ttf")

func _draw():
draw_string(font, Vector2(100, 100), "Hello, Godot 4!")

problem is still

[AThousandShips]

Please provide an MRP to make this easier to test and fix:

• A small Godot project which reproduces the issue, with no unnecessary files included. Be sure to not include the .godot folder in the archive (but keep project.godot).
• Having an MRP is very important for contributors to be able to reproduce the bug in the same way that you are experiencing it. When testing a potential fix for the issue, contributors will use the MRP to validate that the fix is working as intended.
• Drag and drop a ZIP archive to upload it (max 10 MB). Do not select another field until the project is done uploading.
• Note for C# users: If your issue is not C#-specific, please upload a minimal reproduction project written in GDScript. This will make it easier for contributors to reproduce the issue locally as not everyone has a .NET setup available.

[aliule2020]

draw.zip

[aliule2020]

I found the reason of occur of the problem: the argument of width must be -1, or the problem will occur.

[aliule2020]

I found the reason of occur of the problem: the argument of width must be -1, or the problem will occur.
The width of font is useless and waste of time, I suggest to delete this useless argument.