MovieWriter window title isn't visible when using game window embedding

[Calinou]

Tested versions

• Related to The project's window title isn't visible when using a floating game window #101539.
• Reproducible in: 4.4.1.stable, 4.5.dev 4

System information

Godot v4.4.1.stable - Fedora Linux 42 (KDE Plasma Desktop Edition) on X11 - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 5090 (nvidia; 570.144) - AMD Ryzen 9 9950X3D 16-Core Processor (32 threads)

Issue description

The MovieWriter window title override isn't visible when using game window embedding. This wasn't addressed by #101809, presumably because MovieWriter sets the window title directly without going through the scripting API.

cc @Hilderin

Game window embedding enabled (with floating window)

Note that if the floating window is disabled, there's no way to see the window title in the first place.

Game window embedding disabled

Steps to reproduce

• Enable Movie Maker mode in the top-right corner of the editor.
• Run the minimal reproduction project with game window embedding disabled. Notice the window title changing to match MovieWriter's current frame.
• Stop the project, enable game window embedding and run the project again with Movie Maker mode still active. Notice how the window title is no longer updated to match MovieWriter's current status.

Minimal reproduction project (MRP)

test_movie_writer.zip

[bruvzg]

Should be fixable by using Window instead of DisplayServer (tested only on macOS):

diff --git a/servers/movie_writer/movie_writer.cpp b/servers/movie_writer/movie_writer.cpp
index dbbcea6092..b4a4315144 100644
--- a/servers/movie_writer/movie_writer.cpp
+++ b/servers/movie_writer/movie_writer.cpp
@@ -32,6 +32,7 @@
 #include "core/config/project_settings.h"
 #include "core/io/dir_access.h"
 #include "core/os/time.h"
+#include "scene/main/window.h"
 #include "servers/audio/audio_driver_dummy.h"
 #include "servers/display_server.h"
 #include "servers/rendering_server.h"
@@ -191,11 +192,14 @@ void MovieWriter::add_frame() {
 			String::num(movie_time_seconds % 60, 0).pad_zeros(2),
 			String::num(frame_remainder, 0).pad_zeros(2));
 
+	Window *main_window = Window::get_from_id(DisplayServer::MAIN_WINDOW_ID);
+	if (main_window) {
 #ifdef DEBUG_ENABLED
-	DisplayServer::get_singleton()->window_set_title(vformat("MovieWriter: Frame %d (time: %s) - %s (DEBUG)", Engine::get_singleton()->get_frames_drawn(), movie_time, project_name));
+		main_window->set_title(vformat("MovieWriter: Frame %d (time: %s) - %s (DEBUG)", Engine::get_singleton()->get_frames_drawn(), movie_time, project_name));
 #else
-	DisplayServer::get_singleton()->window_set_title(vformat("MovieWriter: Frame %d (time: %s) - %s", Engine::get_singleton()->get_frames_drawn(), movie_time, project_name));
+		main_window->set_title(vformat("MovieWriter: Frame %d (time: %s) - %s", Engine::get_singleton()->get_frames_drawn(), movie_time, project_name));
 #endif
+	}
 
 	RID main_vp_rid = RenderingServer::get_singleton()->viewport_find_from_screen_attachment(DisplayServer::MAIN_WINDOW_ID);
 	RID main_vp_texture = RenderingServer::get_singleton()->viewport_get_texture(main_vp_rid);

Note that if the floating window is disabled, there's no way to see the window title in the first place.

Should we add it somewhere? While title is not the best place for debug info, it seems to be used for in many cases.

[Calinou]

Should we add it somewhere? While title is not the best place for debug info, it seems to be used for in many cases.

Yes, but I'm not sure where it should be displayed so we don't lose space for the main game view.

If the window title is short enough and the editor window is wide enough, we can do something like this: