Project can be duplicated into itself

[samfromcadott]

Tested versions

• Reproducible in Godot 4.5.1

System information

Windows 10 - Godot 4.5.1

Issue description

Project was duplicated into itself which caused an infinite loop

Steps to reproduce

1. I duplicated a project when updating from 4.4 to 4.5
2. The default path for the duplicated project was a child of the project directory
3. Godot entered an infinite loop duplicating the project into itself

Minimal reproduction project (MRP)

N/A

[ArminBolic0]

I think the issue is in the if statement that checks for self-duplication. It only shows an error message but doesn’t stop execution, if return is added afterwards I think it will fix infinite loop problem

[AThousandShips]

There's no infinite loop in that code, the issue is infinite recursion I'd say which is far more complicated

The proper fix here I'd say is to prevent duplicating into itself by checking for the target and preventing it correctly

[Nallebeorn]

Preventing duplicating a project into itself was implemented in #111273 (which is where the code in the screenshot above is from). This issue report is for 4.5.1, which doesn't include that commit. It should already be fixed in the preview builds (4.6-dev2 or later).

[akien-mga]

Fixed by #112699.